Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transport: fix proxy protocol initialization #6301

Merged
merged 1 commit into from
May 7, 2024
Merged

transport: fix proxy protocol initialization #6301

merged 1 commit into from
May 7, 2024

Conversation

mohammed90
Copy link
Member

Resolve #6300

@mohammed90 mohammed90 added the bug 🐞 Something isn't working label May 5, 2024
@mohammed90 mohammed90 added this to the v2.8.0 milestone May 5, 2024
@mohammed90
Copy link
Member Author

@eulores can you please test this PR to validate the fix? You can either grab the CI artifact from here or build from source using xcaddy with the command:

xcaddy build issue-6300

@mohammed90 mohammed90 changed the title transport: fix proxy protocol initializeation transport: fix proxy protocol initialization May 5, 2024
@eulores
Copy link

eulores commented May 5, 2024

I tested this PR and it works as expected.
Thank you very much!

Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks so much @mohammed90 !!

@mholt mholt merged commit d05d715 into master May 7, 2024
23 checks passed
@mholt mholt deleted the issue-6300 branch May 7, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proxy protocol v2, as declared in reverse_proxy / transport http, fails due to unitialized command byte
3 participants