Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd: Switch to TasksMax #108

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

bt90
Copy link
Contributor

@bt90 bt90 commented Dec 28, 2023

Fixes #107

TasksMax is supported since systemd 227 which got released back in 2015.

Copy link
Member

@francislavoie francislavoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just would like @carlwgeorge's review.

Copy link
Collaborator

@carlwgeorge carlwgeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in #107, TasksMax isn't available in RHEL 7's systemd version. To adopt this as is we would need to drop RHEL 7 as a targeted OS, which is a decision for the project maintainers. Alternatively, we can just remove LimitNPROC instead, as there is some question if it is really needed.

@francislavoie
Copy link
Member

Yeah, let's drop LimitNProc for now, and lets add TasksMax in a few months 👍

@bt90 bt90 mentioned this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch systemd unit to TasksMax
3 participants