Skip to content
This repository has been archived by the owner on May 18, 2020. It is now read-only.

update rfc2136 #12

Merged
merged 2 commits into from
Sep 30, 2017
Merged

update rfc2136 #12

merged 2 commits into from
Sep 30, 2017

Conversation

lhemala
Copy link
Contributor

@lhemala lhemala commented Sep 29, 2017

No description provided.

mholt
mholt suggested changes Sep 29, 2017
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the DNS propagation timeout should be optional, with a default value. What do you think? (In other words: another case.)

@lhemala
Copy link
Contributor Author

lhemala commented Sep 30, 2017

Yeah that's reasonable

Should it also default to 60s as in
https://github.com/xenolf/lego/blob/master/providers/dns/rfc2136/rfc2136.go#L33 ?

@mholt
Copy link
Member

mholt commented Sep 30, 2017

Oh, nice find. It looks like an empty timeout defaults to that: https://github.com/xenolf/lego/blob/5a2fd5039fbba3c06b640be91a2c436bc23f74e8/providers/dns/rfc2136/rfc2136.go#L73 - so we can just pass in an empty string for that case and let the library choose the default.

@mholt
Copy link
Member

mholt commented Sep 30, 2017

Looks great! Thanks!

@mholt mholt merged commit a1b594f into caddyserver:master Sep 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lhemala @mholt