Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes when Sign in Flight (under Pilot Options) is initiated. #56

Closed
huguesfcadets opened this issue Mar 15, 2020 · 1 comment
Closed
Assignees
Labels
App Review Comments from the Apple App Review

Comments

@huguesfcadets
Copy link
Member

Next Steps

To resolve this issue, please revise your app and test it on a device to ensure that it runs as expected.

Resources

For information on how to symbolicate and read a crash log, please review Tech Note TN2151 Understanding and Analyzing Application Crash Reports

crashlog-D7F31864-0F66-4891-88B9-B0B114F07DC2.txt
crashlog-8828296F-280C-4A22-9130-5063A8E0F4EE.txt
Screenshot-0314-162432
crashlog-167FA461-B180-4058-B005-0228E7C870AF.txt
Screenshot-0314-162617

@huguesfcadets huguesfcadets changed the title Crashes when Sign in Flight (under Pilot Options) is initiated. App Review - Crashes when Sign in Flight (under Pilot Options) is initiated. Mar 15, 2020
@huguesfcadets huguesfcadets added the App Review Comments from the Apple App Review label Mar 15, 2020
@huguesfcadets huguesfcadets added this to To do in ETS Reporting via automation Mar 15, 2020
@huguesfcadets huguesfcadets changed the title App Review - Crashes when Sign in Flight (under Pilot Options) is initiated. Crashes when Sign in Flight (under Pilot Options) is initiated. Mar 15, 2020
@huguesfcadets huguesfcadets self-assigned this Mar 15, 2020
@huguesfcadets huguesfcadets moved this from To do to In progress in ETS Reporting Mar 15, 2020
@huguesfcadets huguesfcadets moved this from In progress to To do in ETS Reporting Mar 16, 2020
@huguesfcadets huguesfcadets moved this from To do to In progress in ETS Reporting May 3, 2020
@huguesfcadets
Copy link
Member Author

huguesfcadets commented May 3, 2020

Exception:

Thread 1: Exception: "
Your application has presented a UIAlertController (<UIAlertController: 0x7fc267851800>) 
	of style UIAlertControllerStyleActionSheet 
		from UINavigationController (<UINavigationController: 0x7fc26b035a00>). 

The modalPresentationStyle of a UIAlertController with this style is UIModalPresentationPopover. 

You must provide location information for this popover through the alert controller's popoverPresentationController. 

You must provide either a sourceView and sourceRect or a barButtonItem.  

If this information is not known when you present the alert controller, you may provide it in the UIPopoverPresentationControllerDelegate method -prepareForPopoverPresentation."

Fix

controller.popoverPresentationController?.sourceView = cell.contentView // fix #56

The popoverPresentationController will be nil on iOS, so this as no effect when on iPhone.
Using the cell.contentView, will have the popover with a callout pointing to the cell from which the event originated. The same applies to Sign out flight and Sign Out All Squadron Cadets.

huguesf added a commit that referenced this issue May 3, 2020
@huguesfcadets huguesfcadets moved this from In progress to Done in ETS Reporting May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Review Comments from the Apple App Review
Projects
ETS Reporting
  
Done
Development

No branches or pull requests

1 participant