Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show files as well as versions #15

Closed
trombonehero opened this issue Jun 26, 2017 · 4 comments
Closed

Show files as well as versions #15

trombonehero opened this issue Jun 26, 2017 · 4 comments
Assignees
@trombonehero
Labels
enhancement ui

Comments

@trombonehero
Copy link
Contributor

When we import a file-version into the worksheet, we should break it down as a parent file (with a UUID) and child versions.
@trombonehero trombonehero self-assigned this Jun 26, 2017
@HarkonenBade
Copy link
Contributor

Would supporting this be a good first step to collapsing version in the graph helpfully? If so what data would you need on the parent node? Our initial thoughts were uuid, hostuuid and the union of the names of the versions. Also can cytoscape handle giving the parent node the union of it's children's edges in the right situation, or would we also need to emit these?

@trombonehero
Copy link
Contributor Author

As a first cut, I think that the abstract file objects can be generated entirely dynamically in JavaScript: I'll add files to the graph using the file UUID as an ID and the file-version host field as a parent for the file. I can then add a names: new Set() field to the abstract file node's scratch data. So, maybe no OPUS changes required...

@HarkonenBade
Copy link
Contributor

Roger, update if you find things that are needed.

trombonehero added a commit that referenced this issue Jun 27, 2017
@trombonehero
Fix compound node tapping problem.
a874719 
Cytoscape events, like jQuery events, bubble up to compound nodes and then to the core of Cytoscape. We need to check explicitly whether "we" have been tapped before triggering a context menu event.

This should enable the compound-node functionality that we want in #15.
trombonehero added a commit that referenced this issue Jul 2, 2017
@trombonehero
Show files as well as versions in the graph.
acea897 
When we import a file-version, put it into an abstract "file". This file
node can display the filename(s) once, allowing simplification of the
file-version nodes, and it also makes their relationship more obvious.

It is worth noting that the set of names attached to a file node will
depend on the file-versions that have been added to the graph. For
example, if we add a rename operation to the graph, the abstract file
will acquire another potential name.

Closes issue #15.
@trombonehero
Copy link
Contributor Author

Resolved by acea897.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trombonehero trombonehero

Labels
enhancement ui
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trombonehero @HarkonenBade