doing an in check on indexedProperties is stupid -- testing for truth…

…y value is more robust
cadorn · Feb 9, 2010 · cb93518 · cb93518
1 parent c992481
commit cb93518
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/store/sql.js b/lib/store/sql.js
@@ -111,7 +111,7 @@ exports.SQLStore = function(config){
 								}
 								sortAttribute = sortAttribute.substring(1);
 							}
-							if(!sortAttribute in indexedProperties){
+							if(!indexedProperties[sortAttribute]){
 								throw new URIError("Can only sort by " + Object.keys(indexedProperties));
 							}
 							sql += " " + config.table + "." + sortAttribute + " " + orderDir + ",";
@@ -143,7 +143,7 @@ exports.SQLStore = function(config){
 					throw new URIError("Invalid query syntax, unknown type");
 				}
 				function addClause(name, sqlClause){
-					if(!name in indexedProperties){
+					if(!indexedProperties[name]){
 						throw new URIError("Can only query by " + Object.keys(indexedProperties));
 					}
 					if(sql){