-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Username should be unique #46
Comments
Why? Chico Sokol On Thu, Aug 21, 2014 at 12:52 PM, Leonardo Cesar Wolter <
|
We are having issues at guj.com where a troll is creating multiple fake users with the username of other users http://www.guj.com.br/26754-ignorem-e-apenas-um-troll |
:-( Right, we will have to do some manual work to fix this when we deploy our Chico Sokol On Thu, Aug 21, 2014 at 1:18 PM, Leonardo Cesar Wolter <
|
I guess we can just validate the new users from now |
Yes, validate new users will be enough (case insensitive) |
Looks like this commit broke a bunch of test cases: https://travis-ci.org/caelum/mamute/builds/33532614. |
This is partially my fault, in implementing #37 I included a default Delete line 15 in the POM and it should be fixed. |
This is weird, I could run the tests using eclipse. Maybe it will only fail when using mvn tests once the value is on pom, right? I think the best would be putting it at mamute.properties |
I've long since stopped trying to understand Eclipse's weirdness :) I'm able to replicate Travis's results by running |
I fixed it with this: 05b2bb1 It was the best I could do from github, but we should move the pom value to mamute.properties to prevent this kind of weirdness :) |
The idea at the time was that you could run Changing this to be a path to a Hibernate config file would make the code cleaner. I also think putting it in
|
From now, the field
username
of the modelUser
should be unique and not case sensitive.If there's a user called 'leonardo.wolter', no one can create a user called 'Leonardo.wolter'
The text was updated successfully, but these errors were encountered: