Add @Options to PathAnnotationRoutesParser class #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
P.S.: I do not know why the merge is considering that I changed the entire file... |
|
You can do the same to @patch Http verb. Sent from my iPhone On 02/08/2013, at 11:32, Rafael Dipold notifications@github.com wrote:
|
|
Good point @nykolaslima |
|
It's complicated to know what piece of code you changed. Git's diff is considering that all file was modified. :-( |
|
It must be your IDE changing the line endings from LF to CRLF... please redo your changes without it =( |
|
Ok now.. but I swear I am innocent =) |
|
Perfect! |
|
@lucascs can we merge it, right? |
lucascs
added a commit
that referenced
this pull request
Aug 13, 2013
Add @options to PathAnnotationRoutesParser class
|
Thanks! |
|
👍 |
garcia-jj
added a commit
to caelum/vraptor4
that referenced
this pull request
Sep 13, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related with the issue #519
The problem was that
@Optionsonly worked associated with the@Pathannotation.This PR solves the problem by adding the
@Optionsto the list ofPredicate