Using Supplier instead of Callable to get objects as lazy #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 but worth a note on the changelog |
|
Can we add notes in changelog before release? |
|
If I'm not wrong we can draft the next release: |
|
if you want to, just add the note at |
garcia-jj
added a commit
that referenced
this pull request
Sep 1, 2014
Using Supplier instead of Callable to get objects as lazy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
Supplieris the right type to get objects using lazy approach.Since we are using Java 7 without lambdas, we can use Guava Supplier. And when we decide to use Java 8, will too easy to migrate.
Cache is a internal feature, designed to use only in our internal code. So there is no problems to change methods signature.