Skip to content
This repository has been archived by the owner on Mar 8, 2024. It is now read-only.

Filter out all dynamic invoke expressions #295

Closed
wants to merge 2 commits into from

Conversation

FWDekker
Copy link
Member

@FWDekker FWDekker commented Jun 26, 2018

Superseded by #299.

Soot does not fully support dynamic invokes (e.g. lambdas), which sometimes causes problems when ClassConstants are used inside them (see also soot-oss/soot#379). This caused crashes when checking whether a type inside a lambda is a library type. @casperboone and I could not find an easy workaround and instead decided that it would be best to change Schaapi such that dynamic invokes (and thus lambdas) are ignored completely.

@FWDekker FWDekker added the bug Something isn't working label Jun 26, 2018
Copy link
Member

@gandreadis gandreadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Could you perhaps add an integration test with a lambda, to test that this works?

@codecov
Copy link

codecov bot commented Jun 26, 2018

Codecov Report

Merging #295 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #295      +/-   ##
============================================
- Coverage     80.49%   80.44%   -0.06%     
  Complexity      529      529              
============================================
  Files            68       68              
  Lines          1579     1580       +1     
  Branches        250      250              
============================================
  Hits           1271     1271              
- Misses          210      211       +1     
  Partials         98       98
Impacted Files Coverage Δ Complexity Δ
.../usagegraphgenerator/jimple/filters/ValueFilter.kt 80.32% <100%> (-1.34%) 5 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bbe7d7...5b6f282. Read the comment docs.

@FWDekker FWDekker mentioned this pull request Jun 27, 2018
@casperboone
Copy link
Member

Closing in favor of #299.

@casperboone casperboone deleted the filter-dynamic-invoke branch June 27, 2018 13:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants