Skip to content

Commit

Permalink
refactor: Use length of URLs if lesser than maxConcurrency
Browse files Browse the repository at this point in the history
  • Loading branch information
caffeine-addictt committed Apr 14, 2024
1 parent 8a44a28 commit c24e154
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions src/get.go
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ var getCommand = &cobra.Command{
case strategyConcurrent:
// Concurrency with no limit
if getFlags.maxConcurrency == 0 {
fmt.Println("Downloading concurrently... [No limit]")
fmt.Printf("Downloading concurrently... [Use: %d, Max: No limit]", len(argSet))
waitGroup.Add(len(argSet))

for url := range argSet {
Expand All @@ -228,12 +228,13 @@ var getCommand = &cobra.Command{

// Concurrency with limit
} else {
fmt.Printf("Downloading concurrently... [Max: %d]\n", getFlags.maxConcurrency)
waitGroup.Add(int(getFlags.maxConcurrency))
resolvedConcurrency := min(len(argSet), getFlags.maxConcurrency)
fmt.Printf("Downloading concurrently... [Use: %d, Max: %d]\n", resolvedConcurrency, getFlags.maxConcurrency)

// Establish channel and workers
waitGroup.Add(resolvedConcurrency)
ch := make(chan string)
for t := 0; t < int(getFlags.maxConcurrency); t++ {
for t := 0; t < resolvedConcurrency; t++ {
go func() {
for url := range ch {
downloadFile(url)
Expand Down

0 comments on commit c24e154

Please sign in to comment.