Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Continue other jobs even if one job fails #291

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

OctopusET
Copy link
Contributor

Other jobs are canceled when one of the compile jobs fails.
This allows you to check how other things succeed or fail.

Reference: actions/runner#2347

@OctopusET
Copy link
Contributor Author

Here's a test on my repository
https://github.com/OctopusET/cage/actions/runs/6953804611

@OctopusET OctopusET mentioned this pull request Nov 22, 2023
@emersion
Copy link
Contributor

Maybe fail-fast is better here? It seems continue-on-error "prevents a workflow run from failing when a job fails", which isn't exactly what we're looking for here.

This allows other jobs to continue running even if one job fails
@OctopusET
Copy link
Contributor Author

Yes, I agree. continue-on-error is for picking one specific job. In this case, set fail-fast to false would be better.

Copy link
Contributor

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@emersion emersion merged commit 1f3e304 into cage-kiosk:master Nov 22, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants