Implement xdg-decoration #45
Conversation
Hjdskes
force-pushed
the
xdg-decoration
branch
2 times, most recently
from
f96e507
to
d0c2e91
Compare
|
Thanks for working on this. The help message is a bit broken: With the parameter |
cage.c
Outdated
| @@ -84,6 +85,7 @@ usage(FILE *file, const char *cage) | |||
| { | |||
| fprintf(file, "Usage: %s APPLICATION\n" | |||
| "\n" | |||
| " -d\t Don't draw client side decorations, when possible" | |||
There was a problem hiding this comment.
Thanks, good catch.
This commit adds a commandline switch (-d) to disable client side decorations, if possible. In this case, Cage will not draw any decorations of its own, in order to maximize screen real estate. The default behavior remains the same, i.e., if -d is not passed, clients will draw their client side decorations, if any. Fixes #32
Hjdskes
force-pushed
the
xdg-decoration
branch
from
d0c2e91
to
9e36b25
Compare
This is because Firefox does not (yet?) implement the xdg decoration protocol. This feature only works with clients that implement the protocol. One such example client is |
|
That would make sense, but Sway manages to hide CSDs for firefox-wayland. Is that being done with another protocol then? |
|
I asked in |
|
Ah okay, this is more clear now. So in theory with xdg-decoration and server-decoration implemented, this should cover all applications with CSDs. |
GTK still uses the (now deprecated) server-decoration protocol, which is the predecessor to xdg-decoration. Hence, with this commit Cage now also hides decorations on applications such as Firefox. Fixes #47, see also #45 (comment).
GTK still uses the (now deprecated) server-decoration protocol, which is the predecessor to xdg-decoration. Hence, with this commit Cage now also hides decorations on applications such as Firefox. Fixes #47, see also #45 (comment).
This commit adds a commandline switch (
-d) to disable client side decorations, if possible. In this case, Cage will not draw any decorations of its own, in order to maximize screen real estate.The default behavior remains the same, i.e., if
-dis not passed, clients will draw their client side decorations, if any.Fixes #32.