Smart Tooltip Location #153

hkelly93 · 2016-05-18T01:38:26Z

Added a way to determine if the tooltip will appear off the screen.

if you want to use the iterator value, you need to pass in this argument to the tip.show function!

Changed indentation of command to improve style

…f screen.

type="css" is not a proper content-type

Adds support for d3 v4

…ctly

Update package.json to match bower.json

…author Remove duplicate author line from package.json

Use require to load d3 in CommonJS

Fix typo on direction_se() for style consistency.

Update README.md

…linting

- Declare a forgiving minimum for node - Use the latest node (6.1.0) on CircleCI - Greenkeeper branch prefix - Sort the package.json keys

- Removed custom `no-unused-vars` settings and added individual ignores for the two functions instead - Added an extra semicolon to the start of the file to satisfy my concatenation paranoia

Enable linting

d3 micro libraries

rootElement updated from stetro/d3-tip

requires python3

Not sure installation instructions belong in the examples folder.

Update requirejs example

Update showing-and-hiding-tooltips.md

oller · 2017-02-21T16:58:27Z

Any news or progress on resolving the conflicts and merging this in?

It's a great feature to have.

oller · 2017-05-03T14:35:45Z

B-B-B-Bump.

vdh · 2017-06-12T12:15:51Z

While trying to merge #198 (based on this PR), I noticed direction is assigned to function d3TipDirection() { return 'n' }, which accepts nothing and has no side effects.

So… is this code actually functional…?

hkelly93 · 2017-06-12T12:51:55Z

Hmm maybe that line isn't needed. I think this part covers it

` while (i--) {
nodel.classed(directions[i], false);
}

        coords = direction_callbacks.get(dir).apply(this);
        nodel.classed(dir, true)
            .style('top', (coords.top + poffset[0]) + scrollTop + 'px')
            .style('left', (coords.left + poffset[1]) + scrollLeft + 'px');`

…f screen.

hkelly93 · 2017-06-12T12:56:33Z

Ok I removed that line and updated the code.

hkelly93 · 2017-06-12T13:04:00Z

Whoa what happened to my PR lol.

stale · 2018-05-01T17:07:08Z

Hey there! It looks like this issue has been automatically marked as stale because it has not had recent activity. To help the maintainers stay focused, it will be closed if no further activity occurs. Thank you for your contributions.

stale · 2018-07-30T17:20:26Z

Hey there! It looks like this issue has been automatically marked as stale because it has not had recent activity. To help the maintainers stay focused, it will be closed if no further activity occurs. Thank you for your contributions.

ersel and others added 20 commits January 5, 2015 14:08

Update showing-and-hiding-tooltips.md

e4f52a2

if you want to use the iterator value, you need to pass in this argument to the tip.show function!

Fix typo on direction_se() for style consistency.

943ecce

Update README.md

5cd4c72

Changed indentation of command to improve style

Remove duplicate author line from package.json

dc1a7d1

Added a way to change the direction of the tooltip if it'll appear of…

b77a691

…f screen.

make d3-tip work with d3js v4

8aeb6cb

use caret operator for dependency

e3fdc2c

do not change previous formatting

c4e39f0

fix css rendering in chrome

ab1d5fc

type="css" is not a proper content-type

bump to 0.7.0

75d994c

Adds support for d3 v4

Add d3 to package.json to match the bower dependencies

0eea776

Use require to load d3 in the CommonJS loader, and export d3-tip dire…

b6d5eab

…ctly

Merge pull request #160 from vdh/npm-dependencies

72cf425

Update package.json to match bower.json

Merge pull request #144 from panchenko/package-json-remove-duplicate-…

43bbbc0

…author Remove duplicate author line from package.json

Merge pull request #162 from vdh/use-require

6ad188d

Use require to load d3 in CommonJS

Patch version bump because NPM doesn't allow re-publishing

b264d9b

Merge pull request #121 from WesTyler/patch-1

3b29e1b

Fix typo on direction_se() for style consistency.

Merge pull request #123 from peterkshultz/master

5cb5ae6

Update README.md

Fixes #88 / #96 (Return when svg node is falsy)

5f57d02

Whitespace and style fixes, with ESLint and CircleCI for future code …

1a26f86

…linting

caged mentioned this pull request Aug 24, 2016

The tooltip is getting chopped off on top and also on the left corners. #139

Closed

Tim van der Horst and others added 9 commits August 25, 2016 09:08

Enabled camelcase ESLint rule

138b892

NPM / CI tweaks

2d8c41a

- Declare a forgiving minimum for node - Use the latest node (6.1.0) on CircleCI - Greenkeeper branch prefix - Sort the package.json keys

More ESLint tweaks

e6cef99

- Removed custom `no-unused-vars` settings and added individual ignores for the two functions instead - Added an extra semicolon to the start of the file to satisfy my concatenation paranoia

Merge pull request #164 from Caged/linting

9e2192e

Enable linting

Migrate dependencies to d3 micro libraries

6b97914

Merge pull request #161 from vdh/micro-libraries

ed38a11

d3 micro libraries

rootElement copied from stetro/d3-tip

d6e653a

Use functor substitute

ef34fc9

Merge pull request #170 from isaacplmann/rootElement

d2a1b13

rootElement updated from stetro/d3-tip

This was referenced Oct 6, 2016

Support smart directions for elements near screen bounds #8

Closed

Graphical View - tooltip appearing offscreen OHDSI/Atlas#245

Closed

Tim van der Horst and others added 14 commits October 10, 2016 11:51

Fixes #152

3aa7df4

add peer dependencies

02b4f3b

update requirejs example

d977e84

remove peerDependencies and add notice in requirejs.html

477cf48

fix typo

7a7ae84

add a simple server command for serving examples

0da9864

requires python3

Tweak copy

5f1a93b

Not sure installation instructions belong in the examples folder.

Merge pull request #179 from kimxogus/examples

4f4f58f

Update requirejs example

Merge branch 'kimxogus-examples'

1f21ad0

Merge pull request #92 from ersel/patch-1

14cc0fa

Update showing-and-hiding-tooltips.md

recommend npm as the way to install d3-tip

6d299af

Merge branch 'master' of https://github.com/Caged/d3-tip

2c4959b

disable no-plusplus

115e26d

update copyright

4ba5338

vlascik mentioned this pull request May 11, 2017

Fix tooltips appearing offscreen #198

Closed

hkelly93 and others added 2 commits June 12, 2017 08:55

Added a way to change the direction of the tooltip if it'll appear of…

cf659c6

…f screen.

Merge branch 'master' of https://github.com/hkelly93/d3-tip

10fca8c

stale bot added the wontfix label May 1, 2018

stale bot added the stale label Jul 30, 2018

stale bot closed this Aug 6, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Smart Tooltip Location #153

Smart Tooltip Location #153

hkelly93 commented May 18, 2016

oller commented Feb 21, 2017 •

edited

oller commented May 3, 2017

vdh commented Jun 12, 2017

hkelly93 commented Jun 12, 2017

hkelly93 commented Jun 12, 2017

hkelly93 commented Jun 12, 2017

stale bot commented May 1, 2018

stale bot commented Jul 30, 2018

Smart Tooltip Location #153

Smart Tooltip Location #153

Conversation

hkelly93 commented May 18, 2016

oller commented Feb 21, 2017 • edited

oller commented May 3, 2017

vdh commented Jun 12, 2017

hkelly93 commented Jun 12, 2017

hkelly93 commented Jun 12, 2017

hkelly93 commented Jun 12, 2017

stale bot commented May 1, 2018

stale bot commented Jul 30, 2018

oller commented Feb 21, 2017 •

edited