Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timer stop & start functions fix #1154

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

wiklam
Copy link
Collaborator

@wiklam wiklam commented Jun 14, 2021

We want to set up the interrupts while attaching a timer and eventually stop it from invoking interrupts.
Removing unnecessary function tm_select (choosing time source is done while setting up timers in clock.c).
Typo in rtc.c.

@wiklam wiklam added the review please review this PR label Jun 14, 2021
sys/kern/time.c Show resolved Hide resolved
sys/drv/pit.c Show resolved Hide resolved
sys/mips/timer.c Show resolved Hide resolved
@cahirwpz
Copy link
Owner

cahirwpz commented Sep 3, 2021

IIRC The intent of this PR is to change timer drivers so that resource allocation (including interrupt handler registration) is performed only when the driver is attached. This involves masking and unmasking an interrupt in *_start and *_stop timer routines. There's no infrastructure that allows for a single intr_handler_t to be temporarily disabled without tearing it down. Hence we resort to configuring timers in such a way they're effectively disabled. Is that correct?

@cahirwpz cahirwpz removed the review please review this PR label Jun 20, 2022
@cahirwpz cahirwpz added the orphaned needs new owner label Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
orphaned needs new owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants