-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add Dockerfile for docker #72
Conversation
Signed-off-by: Ce Gao <gaoce@caicloud.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign @ddysher
1 similar comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need this? any linked issue or background?
COPY --from=runc /usr/bin/runc /usr/bin/runc | ||
COPY --from=build-env /usr/bin/kubeflow-kernel /usr/bin/kubeflow-kernel | ||
|
||
COPY ./hack/config.yaml /etc/ciao/config.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be ./hack/k8s.config.yaml
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue is to provide a docker-native way to run ciao. k8s.config.yaml works for kubernetes but not work for docker. Users running ciao in Docker should provide the kubeconfig, and k8s.config.yaml does not set it.
It is a quick fix for it.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ddysher The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Ce Gao gaoce@caicloud.io
What this PR does / why we need it:
Add your description
Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #
Special notes for your reviewer:
/cc @your-reviewer
Release note: