Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manuals): update manuals to adapt to changed commands #225

Merged
merged 2 commits into from Jul 2, 2018

Conversation

kdada
Copy link
Collaborator

@kdada kdada commented Jul 2, 2018

What this PR does / why we need it:

Adapt to #211.

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #

Reference to #

Special notes for your reviewer:

/assign @ddysher
/assign @zjj2wry

Release note:

NONE

@caicloud-bot caicloud-bot added release-note-none Denotes a PR that doesn't merit a release note. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 2, 2018
@kdada
Copy link
Collaborator Author

kdada commented Jul 2, 2018

/assign @ddysher
/assign @zjj2wry

@caicloud-bot caicloud-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 2, 2018
@@ -5,10 +5,18 @@

API 文档通常足够使用者使用。但是在微服务场景下,服务之间也会存在调用关系。因此需要使调用者方便快速的进行 API 调用,可以生成客户端以供使用:
```
$ nirvana client ./pkg/api --output ./client
$ nirvana client
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's weird to see a command without verb ...

@ddysher
Copy link
Member

ddysher commented Jul 2, 2018

LGTM

@ddysher
Copy link
Member

ddysher commented Jul 2, 2018

/lgtm

@caicloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ddysher

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Jul 2, 2018
@caicloud-bot caicloud-bot merged commit 2a6a55b into caicloud:master Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants