pyproject: use setuptools' automatic discovery #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com>
By not explicitly defining packages, setuptools will automatically find all packages using the flat-layout strategy. This also fixes the following warnings when building with `python -m build` ``` _Warning: Package 'caikit_nlp.<snip>' is absent from the `packages` configuration. ``` Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com>
dtrifiro
requested review from
alex-jw-brooks,
gkumbhat,
evaline-ju,
gabe-l-hart and
tharapalanivel
as code owners
|
Note that the linting error is (somehow) not related to this change. The relevant fixes can be found here: #240 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By not explicitly defining packages, setuptools will automatically find all packages using the flat-layout strategy.
This also prevents the following warnings to be printed when building using
python -m build: