Improve Support for Default Dataclass Fields #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Honaker <Michael.Honaker@ibm.com>
Signed-off-by: Michael Honaker <Michael.Honaker@ibm.com>
Signed-off-by: Michael Honaker <Michael.Honaker@ibm.com>
Signed-off-by: Michael Honaker <Michael.Honaker@ibm.com>
HonakerM
requested review from
gabe-l-hart,
joerunde,
prashantgupta24,
gkumbhat,
hickeyma,
evaline-ju,
alex-jw-brooks,
tharapalanivel and
aluu317
as code owners
Signed-off-by: Michael Honaker <Michael.Honaker@ibm.com>
HonakerM
force-pushed
the
add_better_default_support
branch
from
fdea0f7
to
a5ae46e
Compare
Signed-off-by: Michael Honaker <Michael.Honaker@ibm.com>
7 tasks
gabe-l-hart
requested changes
Jun 3, 2024
Signed-off-by: Michael Honaker <Michael.Honaker@ibm.com>
gabe-l-hart
approved these changes
Jun 7, 2024
| setattr(cls, annotation, dataclass_defined_default) | ||
| defined_default = dataclass_defined_default | ||
|
|
||
| if isinstance(defined_default, Callable): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR improves the way Caikit handles default fields in 2 main ways. The first is to always honoring dataclass default/default_factory fields while the second is improved visibility in the openapi generation.
Special notes for your reviewer:
I discovered a bug in the vectors code where the vectors assumed default value would be
Noneinstead of thelistdefined in the factoryIf applicable: