Merge pull request #11 from robhanlon22/patch-1

Fix bug where testable ID was a stringified var
caioaao · Oct 29, 2021 · 3758343 · 3758343
2 parents 6e4959c + c40fa4b
commit 3758343
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/caioaao/kaocha_greenlight/test/ns.clj b/src/caioaao/kaocha_greenlight/test/ns.clj
@@ -9,7 +9,7 @@
 (defn- test-var->testable
   [v]
   {::testable/type                          :caioaao.kaocha-greenlight.test/var
-   ::testable/id                            (keyword (str v))
+   ::testable/id                            (keyword (symbol v))
    :caioaao.kaocha-greenlight.test/test-var v})
 
 (defn- test-vars

diff --git a/test/caioaao/kaocha_greenlight/type_test.clj b/test/caioaao/kaocha_greenlight/type_test.clj
@@ -55,15 +55,15 @@
                                            :kaocha.testable/desc   "caioaao.kaocha-greenlight.test-suite.blue-test"
                                            :kaocha.ns/name         'caioaao.kaocha-greenlight.test-suite.blue-test
                                            :kaocha.test-plan/tests [{:kaocha.testable/type                    :caioaao.kaocha-greenlight.test/var
-                                                                     :kaocha.testable/id                      :#'caioaao.kaocha-greenlight.test-suite.blue-test/sample-test
+                                                                     :kaocha.testable/id                      :caioaao.kaocha-greenlight.test-suite.blue-test/sample-test
                                                                      :caioaao.kaocha-greenlight.test/test-var #'caioaao.kaocha-greenlight.test-suite.blue-test/sample-test}]}]}
                 (testable/load test-suite-blue)))
     (is (match? {:kaocha.test-plan/tests [{:kaocha.testable/type   :caioaao.kaocha-greenlight.test/ns
                                            :kaocha.testable/id     :caioaao.kaocha-greenlight.test-suite.red-test
                                            :kaocha.testable/desc   "caioaao.kaocha-greenlight.test-suite.red-test"
                                            :kaocha.ns/name         'caioaao.kaocha-greenlight.test-suite.red-test
                                            :kaocha.test-plan/tests [{:kaocha.testable/type                    :caioaao.kaocha-greenlight.test/var
-                                                                     :kaocha.testable/id                      :#'caioaao.kaocha-greenlight.test-suite.red-test/sample-test
+                                                                     :kaocha.testable/id                      :caioaao.kaocha-greenlight.test-suite.red-test/sample-test
                                                                      :caioaao.kaocha-greenlight.test/test-var #'caioaao.kaocha-greenlight.test-suite.red-test/sample-test}]}]}
                 (testable/load test-suite-red))))