Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET 6 target and ARM64 build #703

Merged
merged 14 commits into from Aug 15, 2022
Merged

Add .NET 6 target and ARM64 build #703

merged 14 commits into from Aug 15, 2022

Conversation

dremin
Copy link
Collaborator

@dremin dremin commented Aug 13, 2022

No description provided.

@dremin
Copy link
Collaborator Author

dremin commented Aug 13, 2022

Will need to set up publish profiles for the various targets and adjust CI accordingly. The goal for this PR is to add a .NET 6 target and keep building for 4.7.1 in CI.

@dremin
Copy link
Collaborator Author

dremin commented Aug 13, 2022

@josuave If we include the framework with Cairo, the installer exe is about 60 MB. I think this is worth it because then users will not need to install .NET 6, it will be safer to offer via auto updates, and we have more freedom to update the framework going forward. Do you agree?

@josuave
Copy link
Collaborator

josuave commented Aug 14, 2022

We can start that way. If there is interest in a framework dependent version then we can supply that later

@dremin dremin changed the title Add .NET 6 target Add .NET 6 target and ARM64 build Aug 14, 2022
@dremin
Copy link
Collaborator Author

dremin commented Aug 14, 2022

The ARM64 build works, but is currently without WinSparkle updater support, as there is no ARM release of WinSparkle.

@dremin dremin marked this pull request as ready for review August 14, 2022 23:25
@dremin dremin marked this pull request as draft August 14, 2022 23:36
@dremin dremin marked this pull request as ready for review August 15, 2022 00:18
@josuave josuave merged commit 886fdef into master Aug 15, 2022
@josuave josuave deleted the net6 branch August 17, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants