Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing preprocessor key words #118

Closed
gep13 opened this issue Dec 15, 2020 · 1 comment · Fixed by #85
Closed

Add missing preprocessor key words #118

gep13 opened this issue Dec 15, 2020 · 1 comment · Fixed by #85
Assignees
Milestone

Comments

@gep13
Copy link
Member

gep13 commented Dec 15, 2020

Currently, within the CakeLanguage file, we include the following:

https://github.com/cake-build/cake-vs/blob/develop/src/Classifier/Languages/CakeLanguage.cs#L14

public static List<string> Preprocessors => new List<string> {@"^[#]{1}(load|r|addin|tool)"};

However, as per the docs here:

https://cakebuild.net/docs/writing-builds/preprocessor-directives

There are actually other directives that we should support.

@gep13 gep13 added this to the 0.3.0 milestone Dec 15, 2020
@gep13 gep13 self-assigned this Dec 15, 2020
@gep13
Copy link
Member Author

gep13 commented Dec 15, 2020

A PR was opened to address this issue:

#85

But this will require to be updated, with the recent changes that were made to the source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant