Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StyleCop #19

Open
gep13 opened this issue Sep 24, 2016 · 7 comments
Open

Add StyleCop #19

gep13 opened this issue Sep 24, 2016 · 7 comments
Assignees
Labels

Comments

@gep13
Copy link
Member

gep13 commented Sep 24, 2016

This will keep @patriksvensson really happy 馃槃

@gep13 gep13 added the Build label Sep 24, 2016
@gep13 gep13 added this to the 0.2.0 milestone Sep 24, 2016
@patriksvensson
Copy link
Member

Oh yes! 馃槅

@gep13 gep13 self-assigned this Sep 26, 2016
gep13 added a commit to gep13/cake-vs that referenced this issue Sep 26, 2016
@gep13
Copy link
Member Author

gep13 commented Sep 30, 2016

@agc93 I am away at DDDNorth this weekend, but hopefully I will get back around to this, and get the PR finished off soon.

@Structed
Copy link

Structed commented Jul 7, 2017

@gep13 If you'd like some help here, I'd be happy to help or even take over and finish this!

@gep13
Copy link
Member Author

gep13 commented Jul 7, 2017

@Structed there is an Open PR where this was started, but I haven't been back to it. If you wanted to continue working there, that would be great!

@Structed
Copy link

Alright - sorry for the long absence...

I imagine the following would need to be done - please add/correct:

  • Upgrade StyleCop.Analyzers to latest version
  • Add stylecop.json to enforce header
  • Fix all StyleCop style warnings

Perhaps even set the build to treat warnings as errors.

However, I believe we'd either need to sync the issue branch with cake-vs/develop or start over.
I tried merging real quick and since this is my first time I have ever looked at an extension's source, I felt pretty lost and eventually abandoned merging.

gep13 added a commit to gep13/cake-vs that referenced this issue Jul 23, 2017
@gep13
Copy link
Member Author

gep13 commented Jul 23, 2017

@Structed that all sounds good to me 馃憤

I have updated the PR that is associated with this issue to the latest code that is on the develop branch. So it should be possible to continue with the work on that branch.

@gep13 gep13 modified the milestone: v0.2.0 Aug 22, 2017
Structed pushed a commit to Structed/cake-vs that referenced this issue Aug 26, 2017
@Structed
Copy link

Structed commented Sep 9, 2017

So after a few tries to get the solution compiled, I guess I need some help getting this to work so I can actually start working on StyleCop.

@gep13, would you be so kind as to give me some guidance? (probably outside this issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants