Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove syntax highlighting #52

Closed
gep13 opened this issue Aug 23, 2017 · 0 comments
Closed

Remove syntax highlighting #52

gep13 opened this issue Aug 23, 2017 · 0 comments
Assignees
@gep13
Labels
Improvement
Milestone
v0.9.0

Comments

@gep13
Copy link
Member

gep13 commented Aug 23, 2017

The syntax highlighting that is provided by this Cake extension is actually preventing it from being able to light up the intellisense that is offered by Omnisharp. This is due to the fact that Omnisharp works with C# files, rather than Cake Files.

What I mean by this is, with this extension in play, Cake files are identified at Cake Script files:

image

When we need them to be identified as C# files:

image

As you can see from these screenshots though. With the default syntax highlighting offered with VSCode for C# files, I don't actually think that there is any further need for custom syntax highlighting.
@gep13 gep13 added this to the v0.9.0 milestone Aug 23, 2017
@gep13 gep13 self-assigned this Aug 23, 2017
@gep13 gep13 mentioned this issue Aug 23, 2017
Closed
gep13 added a commit that referenced this issue Aug 23, 2017
@gep13
(GH-52) Removed syntax highlighting
f52561f 
- Changed language used from cake to csharp where still required, i.e. breakpoints
- Remove syntax, configuration, and grammar
@gep13 gep13 closed this as completed Aug 23, 2017
gep13 added a commit that referenced this issue Oct 26, 2017
@gep13
Merge branch 'release/0.9.0'
8a0cb13 
* release/0.9.0: (35 commits)
  (GH-58) Added Debug Configuration for Mono
  (doc) Updated command information
  Updated command names.
  Added support for installing Cake.Bakery.
  (GH-35) Added information to readme
  (GH-42) Minor tweaks
  Adds debug command as option to guided install. Initial refactoring for opening gen'd file in workspace.
  (GH-52) Removed syntax highlighting
  (maint) Switch to released version of Cake.VsCode
  (GH-50) Switch to prerelease version of Cake.VsCode
  (GH-50) Removed usage of solutioninfo.cs
  (GH-50) Switch language so that mono is installed
  (GH-50) Made build.sh executable
  (GH-50) Added build.sh file
  (GH-50) Added Travis Yml File
  (maint) Switch to https
  (maint) Whitespace changes
  (maint) Renamed functions for consistency
  (maint) Removed explicit use strict from files
  (maint) whitespace changes
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
Improvement
Projects
None yet
Milestone
v0.9.0
Development

No branches or pull requests
1 participant
@gep13