Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Built framework for .NET Core should be NETCoreApp not NETStandard #2303

Closed
bjorkstromm opened this issue Sep 20, 2018 · 2 comments
Closed

Built framework for .NET Core should be NETCoreApp not NETStandard #2303

bjorkstromm opened this issue Sep 20, 2018 · 2 comments

Comments

@bjorkstromm
Copy link
Member

I'd say this should be NETCoreApp,Version=2.1
bjorkstromm added a commit to bjorkstromm/cake that referenced this issue Sep 20, 2018
@bjorkstromm
(cake-buildGH-2303) Use .NETCoreApp instead of .NETStandard
7387a60 
- Fixes cake-build#2303
@bjorkstromm bjorkstromm mentioned this issue Sep 20, 2018
Closed
@adamhathcock
Copy link
Contributor

Ah, yes. This goes back to issues I had.

All entrypoints should target a runtime but shared DLLs should be a standard.

The problem is resolving what the build target is of the current assembly when executing on all the different runtimes. The build target could be a standard or a runtime but it's not consistent in some way. Hopefully, you can correct my mistake :)

@bjorkstromm
Copy link
Member Author

Fixed in #2604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH2303: Use .NETCoreApp instead of .NETStandard bjorkstromm/cake
2 participants
@adamhathcock @bjorkstromm