Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse multiple InternalsVisibleTo attributes from AssemblyInfo #801

Closed
appakz opened this issue Mar 30, 2016 · 1 comment
Closed

Parse multiple InternalsVisibleTo attributes from AssemblyInfo #801

appakz opened this issue Mar 30, 2016 · 1 comment
Assignees
Milestone

Comments

@appakz
Copy link

appakz commented Mar 30, 2016

It's awesome that the AssemblyInfoCreator / AssemblyInfoSettings classes allow for creating AssemblyInfo files with multiple InternalsVisibleTo attributes, but the AssemblyInfoParseResult only exposes a single string property which pulls in the first InternalsVisibleTo defined in the file. I'm using Cake to read in AssemblyInfo files that are under version control, parse them, rev the versions, inject some company/trademark info, then copy that info into a new Cake-generated AssemblyInfo using AssemblyInfoCreator. I'd like to be able to use the built-in AssemblyInfo parsing, but I have a few AssemblyInfo files that define multiple InternalsVisibleTo attributes.

Am I missing some obvious way to accomplish this, or is this a good candidate for an update to AssemblyInfoParseResult?

@patriksvensson
Copy link
Member

@appakz Sorry for not responding until now but I completely missed this issue for some reason.
I went ahead and fixed this for you in #825 and it will hopefully be available in the 0.11.0 release.

@devlead devlead added this to the v0.11.0 milestone Apr 18, 2016
ChrisMaddock pushed a commit to ChrisMaddock/cake that referenced this issue May 5, 2016
This PR adds support for parsing multiple InternalsVisibleTo
attributes from an AssemblyInfo.cs file. The tests for
parsing and creating AssemblyInfo.cs has also been refactored.

This PR also introduces a breaking change since the
property has changed from a string to a List<string>.

Closes cake-build#801.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants