Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssemblyInforParser: Added support for multiple InternalsVisibleTo #825

Merged
merged 1 commit into from Apr 16, 2016
Merged

AssemblyInforParser: Added support for multiple InternalsVisibleTo #825

merged 1 commit into from Apr 16, 2016

Conversation

patriksvensson
Copy link
Member

Closes #801 when merged.

@devlead
Copy link
Member

devlead commented Apr 16, 2016

There seems to be an StyleCop error:
AssemblyInfoParser.cs(98,13,98,19): error : SA1000 : CSharp.Spacing : The spacing around the keyword 'foreach' is invalid. [Z:\Builds\work\93195cd5a0cab8\src\Cake.Common\Cake.Common.csproj]

This PR adds support for parsing multiple InternalsVisibleTo
attributes from an AssemblyInfo.cs file. The tests for
parsing and creating AssemblyInfo.cs has also been refactored.

This PR also introduces a breaking change since the
property has changed from a string to a List<string>.

Closes #801.
@patriksvensson
Copy link
Member Author

Fixed, rebased and squashed.

@devlead
Copy link
Member

devlead commented Apr 16, 2016

LGTM 👍 I'll merge 👌

@devlead devlead merged commit 8ba1df9 into cake-build:develop Apr 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants