New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH1710: GetSubDirectories alias #1711

Merged
merged 1 commit into from Aug 1, 2017

Conversation

Projects
None yet
4 participants
@patridge
Contributor

patridge commented Jul 31, 2017

As described in #1710, this offers a simple Alias to get a list of sub-directories for a given DirectoryPath.

@dnfclas

This comment has been minimized.

dnfclas commented Jul 31, 2017

@patridge,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla2.dotnetfoundation.org.

It will cover your contributions to all .NET Foundation-managed open source projects.
Thanks,
.NET Foundation Pull Request Bot

@dnfclas

This comment has been minimized.

dnfclas commented Jul 31, 2017

@patridge, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, .NET Foundation Pull Request Bot

@dnfclas dnfclas added cla-signed and removed cla-required labels Jul 31, 2017

/// <returns>An absolute directory path.</returns>
[CakeMethodAlias]
[CakeAliasCategory("List")]
public static List<DirectoryPath> GetSubDirectories(this ICakeContext context, DirectoryPath directoryPath)

This comment has been minimized.

@mholo65

mholo65 Jul 31, 2017

Member

For consistency. This should return DirectoryPathCollection

This comment has been minimized.

@mholo65

This comment has been minimized.

@devlead

devlead Jul 31, 2017

Member

For consistency. This should return DirectoryPathCollection

Agreed @mholo65 👍

This comment has been minimized.

@patridge

patridge Jul 31, 2017

Contributor

Good catch! Fixed

@patridge

This comment has been minimized.

Contributor

patridge commented Jul 31, 2017

Let me know if/what I need to do about the TeamCity build failing. I wasn't totally sure what the error was describing when I logged in there as a guest.

@mholo65

This comment has been minimized.

Member

mholo65 commented Aug 1, 2017

@patridge the fail on TeamCity has to do with reference assemblies missing/not found. Bug was introduced in PR #1645 and has nothing to do with your changes.

@devlead @patriksvensson can we get TC Agend with .NET 4.6.2 Targeting pack installed? Also, agent seems to use VS 2015:

[Step 1/1] MSBuild auto-detection: using msbuild version '14.0' from 'C:\Program Files (x86)\MSBuild\14.0\bin\amd64'.
@mholo65

mholo65 approved these changes Aug 1, 2017

LGTM!

@mholo65

This comment has been minimized.

Member

mholo65 commented Aug 1, 2017

@patridge could you squash all commits into one. Thanks!

@devlead

This comment has been minimized.

Member

devlead commented Aug 1, 2017

@mholo65 agents are maintained by JetBrains now, we could probably add a build step to install targeting pack, but best would be if they updated their agents. We'll reach out to them but meanwhile check isn't required.

@devlead devlead changed the title from GetSubDirectories alias to GH1711: GetSubDirectories alias Aug 1, 2017

@devlead devlead force-pushed the patridge:getsubdirectories-alias branch from a3cc264 to 1a9d4bb Aug 1, 2017

@devlead

devlead approved these changes Aug 1, 2017

LGTM 👍 I've rebased and squashed commits, and will merge as soon as CI finishes.

@devlead devlead merged commit 1a9d4bb into cake-build:develop Aug 1, 2017

4 of 5 checks passed

Cake Develop (Cake) - merge TeamCity build failed
Details
CodeFactor No issues found.
Details
ci/bitrise/7a9d707b00881436/pr Passed - OSX Cake
Details
ci/bitrise/b811c91a26b1ea80/pr Passed - Ubuntu Cake
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@devlead devlead changed the title from GH1711: GetSubDirectories alias to GH1710: GetSubDirectories alias Aug 1, 2017

@devlead

This comment has been minimized.

Member

devlead commented Aug 1, 2017

@patridge your changes have been merged, thanks for your contribution 👍

@patridge patridge deleted the patridge:getsubdirectories-alias branch Aug 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment