GH1710: GetSubDirectories alias #1711
Conversation
|
@patridge, It will cover your contributions to all .NET Foundation-managed open source projects. |
|
@patridge, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
| /// <returns>An absolute directory path.</returns> | ||
| [CakeMethodAlias] | ||
| [CakeAliasCategory("List")] | ||
| public static List<DirectoryPath> GetSubDirectories(this ICakeContext context, DirectoryPath directoryPath) |
There was a problem hiding this comment.
For consistency. This should return DirectoryPathCollection
There was a problem hiding this comment.
For consistency. This should return DirectoryPathCollection
Agreed @mholo65 👍
|
Let me know if/what I need to do about the TeamCity build failing. I wasn't totally sure what the error was describing when I logged in there as a guest. |
|
@patridge the fail on TeamCity has to do with reference assemblies missing/not found. Bug was introduced in PR #1645 and has nothing to do with your changes. @devlead @patriksvensson can we get TC Agend with |
|
@patridge could you squash all commits into one. Thanks! |
|
@mholo65 agents are maintained by JetBrains now, we could probably add a build step to install targeting pack, but best would be if they updated their agents. We'll reach out to them but meanwhile check isn't required. |
devlead
changed the title
|
@patridge your changes have been merged, thanks for your contribution 👍 |
As described in #1710, this offers a simple Alias to get a list of sub-directories for a given DirectoryPath.