Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent cake version #23

Closed
deqenq opened this issue Mar 2, 2019 · 2 comments
Closed

Inconsistent cake version #23

deqenq opened this issue Mar 2, 2019 · 2 comments
Labels
improvement

Comments

@deqenq
Copy link
Member

deqenq commented Mar 2, 2019

In file build.ps1 there is defined older version of cake $CAKE_VERSION = "0.23.0" while in proj files and build.sh there is version 0.30.0. It would be nice to align these versions.
As of today the latest Cake version is 0.32.1, so maybe it could be the opportunity to update and align all to the latest version?
@ecampidoglio
Copy link
Member

I generally prefer to compile against the lowest possible version of Cake that's still compatible with the lastest one (i.e. running the script doesn't generate a warning). Right now, that's still version 0.30.0 if I'm not mistaken.

I agree that we should build the addin using the same version of Cake as the one we link against. That means both bootstrappers should use version 0.30.0.

ecampidoglio added a commit that referenced this issue Mar 14, 2019
@ecampidoglio
Merge pull request #25 from deqenq/Inconsistent_cake_version
573dd37 
Updated reference to Cake version 0.30.0 (#23)
@ecampidoglio
Copy link
Member

Merged in 573dd37. Thank you for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ecampidoglio @deqenq