Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-33: Update Cake.FileHelpers to target Cake v1.0.0 #34

Closed
wants to merge 1 commit into from
Closed

GH-33: Update Cake.FileHelpers to target Cake v1.0.0 #34

wants to merge 1 commit into from

Conversation

augustoproiete
Copy link
Member

  • Update references to Cake.Core and Cake.Common to v1.0.0
  • Update .NET Framework target to net461 (was net46) (continues to multi-target netstandard2.0 as before)
  • Update unit tests to run on netcoreapp3.1 (was netcoreapp2.0 non-LTS)

Closes #33

@augustoproiete augustoproiete self-assigned this Feb 9, 2021
@augustoproiete augustoproiete mentioned this pull request Feb 9, 2021
Closed
@augustoproiete augustoproiete force-pushed the update-target-cake-api-v1-0-0 branch 3 times, most recently from d20269b to 9a58f6e Compare February 9, 2021 03:49
nils-a
nils-a approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@nils-a nils-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@augustoproiete
Copy link
Member Author

@nils-a @gep13 CI is failing with a GitVersion error. Have you seen this error before? If not, no worries, I'll investigate later tonight.

@nils-a
Copy link
Contributor

nils-a commented Feb 9, 2021

@augustoproiete force-pushing always upsets AppVeyor. 😄

The problem is, that we "rename" the AppVeyor build to some calculated version string (i.e. here the last one was .3.1-PullRequest.34+2.build.14). Force-Pushing triggers a new build, which calculates the exact same version string and tries to rename the build - this in turn fails because the builds need to be unique. Boom. CI is broken.

I'm not sure whether that is a feature in Cake.Recipe or in GitVersion. (I always wanted to analyze this in more detail to create a corresponding issue, since I feel having the build named nicely is fine but it should not break The Build.)

This was referenced Feb 19, 2021
Closed
Closed
@gep13
Copy link
Member

gep13 commented Feb 25, 2021

@augustoproiete this has been rebased and merged here:
82c1acd

@gep13
Copy link
Member

gep13 commented Feb 25, 2021

@augustoproiete your changes have been merged, thanks for your contribution 👍

@gep13 gep13 closed this Feb 25, 2021
@augustoproiete augustoproiete deleted the update-target-cake-api-v1-0-0 branch February 25, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nils-a nils-a nils-a approved these changes

@Redth Redth Awaiting requested review from Redth

@gep13 gep13 Awaiting requested review from gep13

Assignees

@augustoproiete augustoproiete

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Cake.FileHelpers to target Cake v1.0.0
3 participants
@augustoproiete @nils-a @gep13