Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helper to filter files outside of the repository #240

Closed
pascalberger opened this issue Aug 21, 2017 · 2 comments · Fixed by #281
Closed

Add helper to filter files outside of the repository #240

pascalberger opened this issue Aug 21, 2017 · 2 comments · Fixed by #281
Labels
Improvement
Milestone
2.0.0

Comments

@pascalberger
Copy link
Member

Original issue: https://github.com/cake-contrib/Cake.Prca/issues/48

Issues reported for files outside of the repository should be filtered.

As already implemented in the MsBuild Issue Provider
@pascalberger pascalberger changed the title Issues reported for files outside of the repository should be filtered. Issues reported for files outside of the repository should be filtered for pull requests Feb 15, 2021
@pascalberger pascalberger transferred this issue from cake-contrib/Cake.Issues.PullRequests Feb 15, 2021
@pascalberger pascalberger added the Area:Core:PullRequests Pull request system integration label Aug 20, 2021
@pascalberger
Copy link
Member Author

This would only be relevant for pull request implementation which can handle issues for files which are not part of the pull request

@pascalberger
Copy link
Member Author

This would only be relevant for pull request implementation which can handle issues for files which are not part of the pull request

While some pull request implementations might support files from outside of repository root, we can't support them at the moment, since IIssue.AffectedFileRelativePath is relative to the repository root.

pascalberger added a commit to pascalberger/Cake.Issues that referenced this issue Jul 24, 2022
@pascalberger
(cake-contribGH-240) Add helper methods to validate if a file is part…
20ba2e5 
… of repository
pascalberger added a commit to pascalberger/Cake.Issues that referenced this issue Jul 24, 2022
@pascalberger
(cake-contribGH-240) Add helper methods to validate if a file is part…
316541a 
… of repository
@pascalberger pascalberger mentioned this issue Jul 24, 2022
Merged
@pascalberger pascalberger linked a pull request Jul 24, 2022 that will close this issue
(GH-240) Add helper methods to validate if a file is part of repository #281
Merged
@pascalberger pascalberger added Area:Core Core Cake.Issues component Area:Core:PullRequests Pull request system integration and removed Area:Core:PullRequests Pull request system integration Area:Core Core Cake.Issues component labels Jul 24, 2022
@pascalberger pascalberger changed the title Issues reported for files outside of the repository should be filtered for pull requests Issues reported for files outside of the repository should be filtered Jul 24, 2022
@pascalberger pascalberger added this to the 2.0.0 milestone Jul 24, 2022
pascalberger added a commit that referenced this issue Jul 27, 2022
@pascalberger
(GH-240) Add helper methods to validate if a file is part of reposito…
80b7452 
…ry (#281)
@pascalberger pascalberger removed the Area:Core Core Cake.Issues component label Jul 28, 2022
@pascalberger pascalberger changed the title Issues reported for files outside of the repository should be filtered Add helper to filter files outside of the repository Jul 28, 2022
pascalberger pushed a commit to pascalberger/Cake.Issues that referenced this issue Dec 25, 2023
@renovate
Update dependency xunit to v2.6.0 (cake-contrib#240)
9a9ce4c 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
pascalberger pushed a commit to pascalberger/Cake.Issues that referenced this issue Dec 25, 2023
@renovate
Update dependency xunit.runner.visualstudio to v2.5.0 (cake-contrib#240)
47c0b52 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
pascalberger pushed a commit to pascalberger/Cake.Issues that referenced this issue Dec 25, 2023
@renovate
Update dependency xunit to v2.6.1 (cake-contrib#240)
5a4aed8 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
pascalberger added a commit to pascalberger/Cake.Issues that referenced this issue Apr 6, 2024
@pascalberger
(cake-contribGH-240) Use LitJson for serializing issues
650b345
pascalberger added a commit to pascalberger/Cake.Issues that referenced this issue Apr 6, 2024
@pascalberger
Merge pull request cake-contrib#246 from pascalberger/feature/litjson
af3d7f8 
(cake-contribGH-240) Use LitJson for serializing issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

(GH-240) Add helper methods to validate if a file is part of repository pascalberger/Cake.Issues
1 participant
@pascalberger