Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use binary logging for MSBuild #252

Closed
pascalberger opened this issue Sep 13, 2018 · 4 comments · Fixed by #576
Closed

Use binary logging for MSBuild #252

pascalberger opened this issue Sep 13, 2018 · 4 comments · Fixed by #576
Assignees
Milestone

Comments

@pascalberger
Copy link
Member

We currently use the XmlFileLogger from MSBuildExtensionPack to create a log file which later is parsed by Cake.Isseus. We should replace this with binary logging which is supported in Cake.Issues.MsBuild starting with 0.6.1

@gep13 gep13 added this to the 2.0.0 milestone Sep 9, 2019
@gep13
Copy link
Member

gep13 commented Jul 9, 2020

@pascalberger I am going to remove this from the 2.0.0 milestone for now.

@pascalberger
Copy link
Member Author

We need to be aware that binlogs contain all environment variable, which might include tokens and credentials on build server. We should not publish log file as artifact, but still can use it for internal processing (like for issue parsing)

@gep13
Copy link
Member

gep13 commented Jul 14, 2020

@pascalberger I was actually coming here to ask about this very issue, since I thought I remembered that you could leak information about your setup when using the binary log.

So not ever uploading as an artifact would be the way forward.

Is there an easy way to identify the log as a binary log? Thinking about putting a check into the upload artifact task to make sure that it hasn't inadvertently been included.

@AdmiringWorm
Copy link
Member

Is there an easy way to identify the log as a binary log?

I believe MSBuild (and dotnet) requires the binary log file to end with the file extension .binlog, so it could be identified with that. It would be a bit different if using a custom binary logger, perhaps.

@AdmiringWorm AdmiringWorm changed the title Use binary logging Use binary logging for MSBuild Jul 15, 2020
@AdmiringWorm AdmiringWorm self-assigned this Jul 15, 2020
@AdmiringWorm AdmiringWorm added this to the 2.0.0 milestone Jul 15, 2020
AdmiringWorm added a commit to AdmiringWorm/Cake.Recipe that referenced this issue Jul 15, 2020
AdmiringWorm added a commit to AdmiringWorm/Cake.Recipe that referenced this issue Jul 15, 2020
AdmiringWorm added a commit to AdmiringWorm/Cake.Recipe that referenced this issue Jul 15, 2020
AdmiringWorm added a commit to AdmiringWorm/Cake.Recipe that referenced this issue Jul 15, 2020
AdmiringWorm added a commit to AdmiringWorm/Cake.Recipe that referenced this issue Jul 15, 2020
AdmiringWorm added a commit to AdmiringWorm/Cake.Recipe that referenced this issue Jul 16, 2020
gep13 added a commit that referenced this issue Jul 16, 2020
(GH-252) Change xml logger to binary logger when running msbuild
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants