-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use binary logging for MSBuild #252
Comments
@pascalberger I am going to remove this from the 2.0.0 milestone for now. |
We need to be aware that binlogs contain all environment variable, which might include tokens and credentials on build server. We should not publish log file as artifact, but still can use it for internal processing (like for issue parsing) |
@pascalberger I was actually coming here to ask about this very issue, since I thought I remembered that you could leak information about your setup when using the binary log. So not ever uploading as an artifact would be the way forward. Is there an easy way to identify the log as a binary log? Thinking about putting a check into the upload artifact task to make sure that it hasn't inadvertently been included. |
I believe MSBuild (and dotnet) requires the binary log file to end with the file extension |
(GH-252) Change xml logger to binary logger when running msbuild
We currently use the XmlFileLogger from MSBuildExtensionPack to create a log file which later is parsed by Cake.Isseus. We should replace this with binary logging which is supported in Cake.Issues.MsBuild starting with 0.6.1
The text was updated successfully, but these errors were encountered: