(GH-252) Change xml logger to binary logger when running msbuild #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiringWorm
force-pushed
the
msbuild-binary-logging
branch
3 times, most recently
from
9d1f0e6
to
d04b2e0
Compare
|
Integration tests passed, appveyor contains report artifact: https://ci.appveyor.com/project/AdmiringWorm/cake-recipe-tests/builds/34120685 |
|
@AdmiringWorm are you in a position to rebase this one, and I will get it merged in? |
|
@gep13 on it |
AdmiringWorm
force-pushed
the
msbuild-binary-logging
branch
from
d04b2e0
to
40c882b
Compare
|
and done + checks complete |
|
@AdmiringWorm your changes have been merged, thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces the already used XMLLogger with a the same BinaryLogger
that is used by Cake.Issues.MSBuild, and makes it equal to the same logging capabilities
as the implementation in pull request #575
resolves #252