Using of Cake.Recipe is tightly coupled with AppVeyor

[vhatsura]

Hi, guys!

Big thanks for Cake.Recipe which is really simplify CI configuration.

However, as I see, Cake.Recipe has some limitations, such as tightly coupled with AppVeyor CI:

Cake.Recipe/Cake.Recipe/Content/parameters.cake

Line 508 in eed2a05

IsMainRepository = StringComparer.OrdinalIgnoreCase.Equals(string.Concat(repositoryOwner, "/", repositoryName), buildSystem.AppVeyor.Environment.Repository.Name);

@RLittlesII already raised issue related to this (#188), but I suggest to create a generic CIProvider, which will hide a really Build system Provider.

What do you think about it?

[pascalberger]

We're definitely interested in having full support for different build servers inside Cake.Recipe. In the future we would like to give addin authors, which are hosting their addin inside the cake-contrib organization, the option to use Azure Pipeline builds additional to AppVeyor (as this for example would give us more parallel build pipelines), and as most of them are using Cake.Recipe this would require some work to abstract the build system integration.

That said I cannot give you an estimated time when this will be finished, as people working on this only have a limited amount of time. If you're interested in contributing, we would be happy to discuss possible implementations and accept PRs.

[vhatsura]

Hi, @pascalberger.

I understand your point about limited time and I definitely interested in contributing.

So, I suggest the following strategy:

1. Move all stuff which is working with BuildSystem to separate class which encapsulates work with AppVeyor
2. Implement tasks to support Azure Pipelines build system (as you mentioned )
3. Implement checking build system at runtime and change logic of getting environment info depending on build system.

If you agree with this strategy, I will be happy to start contribute these changes.

And another question, which is not related to this issue. Do you think about migration to Frosting? It seems can simplify Cake.Recipe development.

[gep13]

@vhatsura I have merged in your work in #373 and I have also taken the steps to rename the top level AppVeyor task to be ContinuousIntegration instead. There may well be some tidy up that needs to happen for everything to work properly, but could I ask you to take the latest pre-release version of Cake.Recipe for a spin on your Azure Pipelines, to see if they are working as you would expect.

[gep13]

Cake.Recipe now supports running on AppVeyor, TeamCity, Azure Pipelines, Travis CI and of course locally on a developer machine. I think we can go ahead and close this out.