Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use msbuild on unix when it is installed #379

Closed
Cheesebaron opened this issue Jul 11, 2019 · 4 comments · Fixed by #545
Closed

Use msbuild on unix when it is installed #379

Cheesebaron opened this issue Jul 11, 2019 · 4 comments · Fixed by #545
Assignees
@AdmiringWorm
Labels
Improvement
Milestone
2.0.0

Comments

@Cheesebaron
Copy link

xbuild isn't capable of building anything new, such as projects using the SDK style csproj files. It hasn't been necessary to use xbuild on macOS for a very long time. The only reason you would use it, would be to get it to color the build output.

Please switch to msbuild also when not running on windows: https://github.com/cake-contrib/Cake.Recipe/blob/develop/Cake.Recipe/Content/build.cake#L173
@Cheesebaron Cheesebaron mentioned this issue Jul 11, 2019
Closed
@gep13 gep13 added this to the 2.0.0 milestone Sep 9, 2019
@gep13
Copy link
Member

gep13 commented Jul 9, 2020

@AdmiringWorm would you be up for taking a stab at this one as well?

@AdmiringWorm
Copy link
Member

Sure, I can do that

@AdmiringWorm AdmiringWorm self-assigned this Jul 9, 2020
AdmiringWorm added a commit to AdmiringWorm/Cake.Recipe that referenced this issue Jul 9, 2020
@AdmiringWorm
(cake-contribGH-379) Use msbuild on unix when it is available
bd4366f 
This includes a fallback to xbuild if msbuild could not be found
@AdmiringWorm AdmiringWorm mentioned this issue Jul 9, 2020
Merged
@AdmiringWorm AdmiringWorm changed the title xbuild is broken Use msbuild on unix when it is installed Jul 9, 2020
AdmiringWorm added a commit to AdmiringWorm/Cake.Recipe that referenced this issue Jul 10, 2020
@AdmiringWorm
(cake-contribGH-379) Use msbuild on unix when it is available
73274d3 
This includes a fallback to xbuild if msbuild could not be found
AdmiringWorm added a commit to AdmiringWorm/Cake.Recipe that referenced this issue Jul 10, 2020
@AdmiringWorm
(cake-contribGH-379) Use msbuild on unix when it is available
1b0aaa0 
This includes a fallback to xbuild if msbuild could not be found
@AdmiringWorm
Copy link
Member

This issue may have to be postponed again, depending on the outcome of issue #552 .
Currently, it is not possible to run Cake.Recipe on Unix with the current codebase

@gep13
Copy link
Member

gep13 commented Jul 10, 2020

@AdmiringWorm as discussed on Gitter, we have pinned to 5.0.1 of GitVersion.Commandline, so running on Unix should now get passed the GitVersion execution errors, and hopefully allow answering some of the other remaining questions about running msbuild/xbuild.

AdmiringWorm added a commit to AdmiringWorm/Cake.Recipe that referenced this issue Jul 10, 2020
@AdmiringWorm
(cake-contribGH-379) Use msbuild on unix when it is available
c637282 
This includes a fallback to xbuild if msbuild could not be found
AdmiringWorm added a commit to AdmiringWorm/Cake.Recipe that referenced this issue Jul 11, 2020
@AdmiringWorm
(cake-contribGH-379) Use msbuild on unix when it is available
3196e9e 
This includes a fallback to xbuild if msbuild could not be found
gep13 added a commit that referenced this issue Jul 11, 2020
@gep13
Merge pull request #545 from AdmiringWorm/change-to-msbuild-unix
01dd22b 
(GH-379) Use msbuild on unix when it is available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdmiringWorm AdmiringWorm

Labels
Improvement
Projects
None yet
Milestone
2.0.0
3 participants
@Cheesebaron @gep13 @AdmiringWorm