(GH-379) Use msbuild on unix when it is available #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiringWorm
force-pushed
the
change-to-msbuild-unix
branch
2 times, most recently
from
73274d3
to
1b0aaa0
Compare
|
@AdmiringWorm are you still testing some things for this, or is it ready. In principle, I have no objections to this going in. |
|
@gep13 I can't test it because it won't get past the GitVersion failures. |
AdmiringWorm
force-pushed
the
change-to-msbuild-unix
branch
from
1b0aaa0
to
c637282
Compare
|
Running integration tests: Once this are all green (or at least until coveralls execution), then I will mark this one as ready. |
This includes a fallback to xbuild if msbuild could not be found
AdmiringWorm
force-pushed
the
change-to-msbuild-unix
branch
from
c637282
to
3196e9e
Compare
|
@gep13 I believe this one is now ready for a review |
|
@AdmiringWorm thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the ability to use msbuild on unix platforms when the executable is available.
With a fallback to xbuild if msbuild could not be found
resolves #379