Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter shouldRunGitVersion should be renamed #604

Closed
gep13 opened this issue Aug 3, 2020 · 0 comments · Fixed by #609
Closed

Parameter shouldRunGitVersion should be renamed #604

gep13 opened this issue Aug 3, 2020 · 0 comments · Fixed by #609
Labels
Breaking change
Milestone
2.0.0

Comments

@gep13
Copy link
Member

gep13 commented Aug 3, 2020

There was a change in Cake.Recipe to allow overridding the usage of GitVersion to calculate repository version number. As a result, the shouldRunGitVersion parameter isn't really true anymore.

This should perhaps be renamed to shouldCalculateVersion
@gep13 gep13 added this to the 2.0.0 milestone Aug 3, 2020
gep13 added a commit to gep13/Cake.Recipe that referenced this issue Aug 4, 2020
@gep13
(cake-contribGH-604) Rename shouldRunGitVersion parameter
6a25a56 
Since this can be used when not using GitVersion.
gep13 added a commit to gep13/Cake.Recipe that referenced this issue Aug 4, 2020
@gep13
(cake-contribGH-604) Rename shouldRunGitVersion parameter
3337b95 
Since this can be used when not using GitVersion.
@gep13 gep13 mentioned this issue Aug 4, 2020
Merged
AdmiringWorm added a commit that referenced this issue Aug 4, 2020
@AdmiringWorm
Merge pull request #609 from gep13/feature/GH-604
7a2137c 
(GH-604) Rename shouldRunGitVersion parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking change
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

(GH-604) Rename shouldRunGitVersion parameter gep13/Cake.Recipe
1 participant
@gep13