Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-604) Rename shouldRunGitVersion parameter #609

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

gep13
Copy link
Member

@gep13 gep13 commented Aug 4, 2020

Since this can be used when not using GitVersion.

Fixes #604

Since this can be used when not using GitVersion.
@gep13 gep13 requested a review from AdmiringWorm August 4, 2020 19:33
Copy link
Member

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdmiringWorm AdmiringWorm merged commit 7a2137c into cake-contrib:develop Aug 4, 2020
@AdmiringWorm
Copy link
Member

@gep13 your changes have been merged, thanks for your contribution 👍

@gep13 gep13 deleted the feature/GH-604 branch August 4, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameter shouldRunGitVersion should be renamed
2 participants