-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chocolatey packages not pushed in some scenarios #801
Comments
AdmiringWorm
added a commit
to AdmiringWorm/Cake.Recipe
that referenced
this issue
Mar 1, 2021
AdmiringWorm
added a commit
to AdmiringWorm/Cake.Recipe
that referenced
this issue
Mar 1, 2021
gep13
pushed a commit
to AdmiringWorm/Cake.Recipe
that referenced
this issue
Mar 8, 2021
gep13
pushed a commit
to AdmiringWorm/Cake.Recipe
that referenced
this issue
Mar 8, 2021
gep13
added a commit
that referenced
this issue
Mar 8, 2021
(GH-801) Update to push Chocolatey packages on Windows platforms
gep13
added a commit
that referenced
this issue
Mar 15, 2021
🎉 This issue has been resolved in version 2.2.1 🎉 The release is available on: Your GitReleaseManager bot 📦🚀 |
gep13
added a commit
to gep13/Cake.Recipe
that referenced
this issue
Mar 15, 2021
* hotfix/2.2.1: (cake-contrib#811) Add cake-recipe tag to nuspec (cake-contrib#800) Add IsPullRequest criteria to tasks (cake-contribGH-793) error when vcsroot.branch is missing (cake-contribGH-801) Update to try pushing chocolatey packages on Windows platform (cake-contrib#805) Fix string formatting syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In some cases a when a user has set the preferred build platform to something other than Windows, then Chocolatey packages would never gets pushed.
This seems to happen because we restrict the tasks related to pushing packages to only do the work on the preferred platform, while the Chocolatey package is only created on a Windows platform (the method for pushing the packages also never gets called on windows in these cases).
My suggestion is to remove the criteria of only running the publishing tasks on a certain build platform and rather add checks inside the tasks to see if the correct platform is being used instead before calling the Chocolatey or NuGet publishing methods.
/cc @gep13
The text was updated successfully, but these errors were encountered: