Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chocolatey packages not pushed in some scenarios #801

Closed
AdmiringWorm opened this issue Feb 28, 2021 · 1 comment · Fixed by #802
Closed

Chocolatey packages not pushed in some scenarios #801

AdmiringWorm opened this issue Feb 28, 2021 · 1 comment · Fixed by #802
Labels
Bug
Milestone
2.2.1

Comments

@AdmiringWorm
Copy link
Member

In some cases a when a user has set the preferred build platform to something other than Windows, then Chocolatey packages would never gets pushed.

This seems to happen because we restrict the tasks related to pushing packages to only do the work on the preferred platform, while the Chocolatey package is only created on a Windows platform (the method for pushing the packages also never gets called on windows in these cases).

My suggestion is to remove the criteria of only running the publishing tasks on a certain build platform and rather add checks inside the tasks to see if the correct platform is being used instead before calling the Chocolatey or NuGet publishing methods.

/cc @gep13
@AdmiringWorm AdmiringWorm added this to the 2.2.1 milestone Mar 1, 2021
AdmiringWorm added a commit to AdmiringWorm/Cake.Recipe that referenced this issue Mar 1, 2021
@AdmiringWorm
(cake-contribGH-801) Update to try pushing chocolatey packages on Win…
16ad2f7 
…dows platform
@AdmiringWorm AdmiringWorm mentioned this issue Mar 1, 2021
Merged
AdmiringWorm added a commit to AdmiringWorm/Cake.Recipe that referenced this issue Mar 1, 2021
@AdmiringWorm
(cake-contribGH-801) Update to try pushing chocolatey packages on Win…
52964be 
…dows platform
gep13 pushed a commit to AdmiringWorm/Cake.Recipe that referenced this issue Mar 8, 2021
@AdmiringWorm @gep13
(cake-contribGH-801) Update to try pushing chocolatey packages on Win…
f0ce996 
…dows platform
gep13 pushed a commit to AdmiringWorm/Cake.Recipe that referenced this issue Mar 8, 2021
@AdmiringWorm @gep13
(cake-contribGH-801) Update to try pushing chocolatey packages on Win…
03aeec2 
…dows platform
gep13 added a commit that referenced this issue Mar 8, 2021
@gep13
Merge pull request #802 from AdmiringWorm/win-choco
11b2dfd 
(GH-801) Update to push Chocolatey packages on Windows platforms
@gep13 gep13 linked a pull request Mar 8, 2021 that will close this issue
(GH-801) Update to push Chocolatey packages on Windows platforms #802
Merged
@gep13 gep13 closed this as completed Mar 8, 2021
gep13 added a commit that referenced this issue Mar 15, 2021
@gep13
Merge branch 'hotfix/2.2.1'
51fc445 
* hotfix/2.2.1:
  (#811) Add cake-recipe tag to nuspec
  (#800) Add IsPullRequest criteria to tasks
  (GH-793) error when vcsroot.branch is missing
  (GH-801) Update to try pushing chocolatey packages on Windows platform
  (#805) Fix string formatting syntax
@cake-contrib-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.2.1 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

gep13 added a commit to gep13/Cake.Recipe that referenced this issue Mar 15, 2021
@gep13
Merge branch 'hotfix/2.2.1' into develop
e54bc8f 
* hotfix/2.2.1:
  (cake-contrib#811) Add cake-recipe tag to nuspec
  (cake-contrib#800) Add IsPullRequest criteria to tasks
  (cake-contribGH-793) error when vcsroot.branch is missing
  (cake-contribGH-801) Update to try pushing chocolatey packages on Windows platform
  (cake-contrib#805) Fix string formatting syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
2.2.1
Development

Successfully merging a pull request may close this issue.

(GH-801) Update to push Chocolatey packages on Windows platforms AdmiringWorm/Cake.Recipe
3 participants
@gep13 @AdmiringWorm @cake-contrib-bot