Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update JetBrains.ReSharper.CommandLineTools #862

Closed
nils-a opened this issue Aug 30, 2021 · 2 comments · Fixed by #869
Closed

update JetBrains.ReSharper.CommandLineTools #862

nils-a opened this issue Aug 30, 2021 · 2 comments · Fixed by #869
Labels
Improvement
Milestone
3.0.0

Comments

@nils-a
Copy link
Contributor

nils-a commented Aug 30, 2021 •
edited

The current version in use produces the following error, if VS 2022 is installed:

========================================
InspectCode
========================================
JetBrains Inspect Code 2020.3.2
Running on AMD 64 in 64-bit mode, .NET runtime 4.0.30319.42000 under Microsoft Windows NT 10.0.19043.0
Custom settings layer is mounted. Used file E:\dev\cake\cake-contrib\Cake.ESLint\src\Cake.ESLint.sln.DotSettings
Enabled solution-wide analysis according to Inspect Code command line Setting.
Warning: Do not know VsVersionToYearString for VS version 17.0.
Warning: Do not know VsVersionToYearString for VS version 17.0.
Using toolset version 17.0 from “C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin”
Configuration: Debug, Platform: Any CPU
Unknown tools version: 17.0

--- EXCEPTION #1/1 [LoggerException]
Message = “Unknown tools version: 17.0”

The minimal required version is 2021.2.0

However, this results in the following warning (and obviously in one unneeded build):

Warning: Starting from version 2021.2, InspectCode builds the target solution before starting the analysis to make sure it only finds relevant code issues.
To explicitly accept the new behavior and suppress this warning, use the '--build' option.
To match the behavior in previous versions and skip the build, use '--no-build'.
@nils-a
Copy link
Contributor Author

nils-a commented Aug 30, 2021

A workaround is setting

ToolSettings.SetToolPreprocessorDirectives(
    reSharperTools: "#tool nuget:?package=JetBrains.ReSharper.CommandLineTools&version=2021.2.0");

in the main Cake script

@nils-a nils-a mentioned this issue Oct 21, 2021
Closed
nils-a added a commit to nils-a/Cake.Recipe that referenced this issue Nov 9, 2021
@nils-a
(cake-contrib#862) bumped JetBrains.ReSharper.CommandLineTools
9788449 
to 2021.2.1, to support ToolsVersion 17 (VS 2022)
@nils-a nils-a mentioned this issue Nov 9, 2021
Merged
@gep13 gep13 added this to the 3.0.0 milestone Dec 16, 2021
gep13 pushed a commit to nils-a/Cake.Recipe that referenced this issue Dec 16, 2021
@nils-a @gep13
(cake-contrib#862) bumped JetBrains.ReSharper.CommandLineTools
eaa1e46 
to 2021.2.1, to support ToolsVersion 17 (VS 2022)
gep13 added a commit that referenced this issue Dec 16, 2021
@gep13
Merge pull request #869 from nils-a/feature/GH-862
88a2fa7 
(#862) bumped JetBrains.ReSharper.CommandLineTools
cake-contrib-bot pushed a commit that referenced this issue Dec 16, 2021
@web-flow
Continuous Integration Publish: 88a2fa7
dcc8887 
Merge pull request #869 from nils-a/feature/GH-862

(#862) bumped JetBrains.ReSharper.CommandLineTools
gep13 added a commit that referenced this issue Aug 8, 2022
@gep13
Merge branch 'release/3.0.0'
724eb7e 
* release/3.0.0: (59 commits)
  (#803) Remove usage of MyGet feed
  (build) Update to Cake 1.3.0
  (#723) Use alias for getting Arguments
  (#762) Update Cake and Cake.Issues.Recipe
  (#854) modified resolution of nuget
  (#854) modified resolution of RequireToolNotRegistered
  (GH-857) Update Cake.Coveralls reference from 1.0.1 to 1.1.0
  (GH-859) Update Cake.Gitter reference from 1.0.2 to 1.1.0
  (#862) bumped JetBrains.ReSharper.CommandLineTools
  (#873) Remove usage of DupFinder
  (#845) specified the full versions of GitHub actions
  Bump actions/checkout from 2.3.4 to 2.4.0
  Bump cake-build/cake-action from 1.3.0 to 1.4.0
  Bump gittools/actions from 0.9.9 to 0.9.11
  Bump actions/cache from 2.1.5 to 2.1.7
  (maint) FIx spelling mistake
  Bump actions/cache from 2.1.4 to 2.1.5
  Bump cake-build/cake-action from 1 to 1.3.0
  (GH-849) Update Cake.Wyam reference from 2.2.10 to 2.2.12
  (#847) Bump CakeContrib.Guidelines to v1.1.1 to update NuGet package icon
  ...
cake-contrib-bot pushed a commit that referenced this issue Aug 8, 2022
@gep13
Continuous Integration Publish: 724eb7e
bd7975c 
Merge branch 'release/3.0.0'

* release/3.0.0: (59 commits)
  (#803) Remove usage of MyGet feed
  (build) Update to Cake 1.3.0
  (#723) Use alias for getting Arguments
  (#762) Update Cake and Cake.Issues.Recipe
  (#854) modified resolution of nuget
  (#854) modified resolution of RequireToolNotRegistered
  (GH-857) Update Cake.Coveralls reference from 1.0.1 to 1.1.0
  (GH-859) Update Cake.Gitter reference from 1.0.2 to 1.1.0
  (#862) bumped JetBrains.ReSharper.CommandLineTools
  (#873) Remove usage of DupFinder
  (#845) specified the full versions of GitHub actions
  Bump actions/checkout from 2.3.4 to 2.4.0
  Bump cake-build/cake-action from 1.3.0 to 1.4.0
  Bump gittools/actions from 0.9.9 to 0.9.11
  Bump actions/cache from 2.1.5 to 2.1.7
  (maint) FIx spelling mistake
  Bump actions/cache from 2.1.4 to 2.1.5
  Bump cake-build/cake-action from 1 to 1.3.0
  (GH-849) Update Cake.Wyam reference from 2.2.10 to 2.2.12
  (#847) Bump CakeContrib.Guidelines to v1.1.1 to update NuGet package icon
  ...
@cake-contrib-bot
Copy link
Contributor

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

cake-contrib-bot pushed a commit that referenced this issue Aug 8, 2022
@gep13
Continuous Integration Publish: 724eb7e
6a6207d 
Merge branch 'release/3.0.0'

* release/3.0.0: (59 commits)
  (#803) Remove usage of MyGet feed
  (build) Update to Cake 1.3.0
  (#723) Use alias for getting Arguments
  (#762) Update Cake and Cake.Issues.Recipe
  (#854) modified resolution of nuget
  (#854) modified resolution of RequireToolNotRegistered
  (GH-857) Update Cake.Coveralls reference from 1.0.1 to 1.1.0
  (GH-859) Update Cake.Gitter reference from 1.0.2 to 1.1.0
  (#862) bumped JetBrains.ReSharper.CommandLineTools
  (#873) Remove usage of DupFinder
  (#845) specified the full versions of GitHub actions
  Bump actions/checkout from 2.3.4 to 2.4.0
  Bump cake-build/cake-action from 1.3.0 to 1.4.0
  Bump gittools/actions from 0.9.9 to 0.9.11
  Bump actions/cache from 2.1.5 to 2.1.7
  (maint) FIx spelling mistake
  Bump actions/cache from 2.1.4 to 2.1.5
  Bump cake-build/cake-action from 1 to 1.3.0
  (GH-849) Update Cake.Wyam reference from 2.2.10 to 2.2.12
  (#847) Bump CakeContrib.Guidelines to v1.1.1 to update NuGet package icon
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

(#862) bumped JetBrains.ReSharper.CommandLineTools nils-a/Cake.Recipe
3 participants
@nils-a @gep13 @cake-contrib-bot