Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cake Recipe scripts to support Cake 1.0 #723

Closed
pascalberger opened this issue Nov 5, 2020 · 2 comments · Fixed by #879
Closed

Update Cake Recipe scripts to support Cake 1.0 #723

pascalberger opened this issue Nov 5, 2020 · 2 comments · Fixed by #879
Milestone

Comments

@pascalberger
Copy link
Member

Version 2.0.1 of Cake.Recipe doesn't run with Cake 1.0 RC.

Stacktrace:

Error: System.AggregateException: One or more errors occurred. ---> System.NullReferenceException: Object reference not set to an instance of an object.
   at Submission#0.GetConfiguration(ICakeContext context)
   at Submission#0.BuildParameters.SetParameters(ICakeContext context, BuildSystem buildSystem, DirectoryPath sourceDirectoryPath, String title, FilePath solutionFilePath, DirectoryPath solutionDirectoryPath, DirectoryPath rootDirectoryPath, DirectoryPath testDirectoryPath, String testFilePattern, String integrationTestScriptPath, String resharperSettingsFileName, String repositoryOwner, String repositoryName, String appVeyorAccountName, String appVeyorProjectSlug, Boolean shouldPostToGitter, Boolean shouldPostToSlack, Boolean shouldPostToTwitter, Boolean shouldPostToMicrosoftTeams, Boolean shouldSendEmail, Boolean shouldDownloadMilestoneReleaseNotes, Boolean shouldDownloadFullReleaseNotes, Boolean shouldNotifyBetaReleases, Boolean shouldDeleteCachedFiles, Boolean shouldUseDeterministicBuilds, FilePath milestoneReleaseNotesFilePath, FilePath fullReleaseNotesFilePath, Boolean shouldRunChocolatey, Boolean shouldPublishGitHub, Boolean shouldGenerateDocumentation, Boolean shouldDocumentSourceFiles, Boolean shouldRunDupFinder, Boolean shouldRunInspectCode, Boolean shouldRunCoveralls, Boolean shouldRunCodecov, Boolean shouldRunDotNetCorePack, Boolean shouldBuildNugetSourcePackage, Boolean shouldRunIntegrationTests, Boolean shouldCalculateVersion, Nullable`1 shouldUseTargetFrameworkPath, Nullable`1 transifexEnabled, TransifexMode transifexPullMode, Int32 transifexPullPercentage, String gitterMessage, String microsoftTeamsMessage, String twitterMessage, DirectoryPath wyamRootDirectoryPath, DirectoryPath wyamPublishDirectoryPath, FilePath wyamConfigurationFile, String wyamRecipe, String wyamTheme, String wyamSourceFiles, String webHost, String webLinkRoot, String webBaseEditUrl, FilePath nuspecFilePath, Boolean isPublicRepository, FilePath nugetConfig, ICollection`1 nuGetSources, Boolean treatWarningsAsErrors, String masterBranchName, String developBranchName, String emailRecipient, String emailSenderName, String emailSenderAddress, DirectoryPath restorePackagesDirectory, List`1 packageSourceDatas, PlatformFamily preferredBuildAgentOperatingSystem, BuildProviderType preferredBuildProviderType)
   at Submission#0.<<Initialize>>d__0.MoveNext()
--- End of stack trace from previous location where exception was thrown ---

Issue is at

var arguments = (IDictionary<string, string>)context.Arguments.GetType().GetProperty("Arguments").GetValue(context.Arguments);
which is no longer a dictionary

@augustoproiete
Copy link
Member

augustoproiete commented Feb 9, 2021

Closing this one in favor of #762 (Support for Cake 1.0 RTM)

Turns out #762 is only about updating the addins that Cake.Recipe depend on, whilst this is about updating the Cake scripts within Cake recipe. Reopening...

@augustoproiete augustoproiete changed the title Support Cake 1.0 RC Update Cake Recipe scripts to support Cake 1.0 Feb 15, 2021
gep13 added a commit to gep13/Cake.Recipe that referenced this issue Dec 17, 2021
Rather than use the hack that was being used, make use of the Arguments
alias which has now been created.
@gep13 gep13 linked a pull request Dec 17, 2021 that will close this issue
@gep13 gep13 added this to the 3.0.0 milestone Dec 17, 2021
gep13 added a commit to gep13/Cake.Recipe that referenced this issue Dec 17, 2021
Rather than use the hack that was being used, make use of the Arguments
alias which has now been created.
gep13 added a commit that referenced this issue Dec 17, 2021
(#723) Use alias for getting Arguments
@gep13 gep13 closed this as completed Dec 17, 2021
gep13 added a commit that referenced this issue Aug 8, 2022
* release/3.0.0: (59 commits)
  (#803) Remove usage of MyGet feed
  (build) Update to Cake 1.3.0
  (#723) Use alias for getting Arguments
  (#762) Update Cake and Cake.Issues.Recipe
  (#854) modified resolution of nuget
  (#854) modified resolution of RequireToolNotRegistered
  (GH-857) Update Cake.Coveralls reference from 1.0.1 to 1.1.0
  (GH-859) Update Cake.Gitter reference from 1.0.2 to 1.1.0
  (#862) bumped JetBrains.ReSharper.CommandLineTools
  (#873) Remove usage of DupFinder
  (#845) specified the full versions of GitHub actions
  Bump actions/checkout from 2.3.4 to 2.4.0
  Bump cake-build/cake-action from 1.3.0 to 1.4.0
  Bump gittools/actions from 0.9.9 to 0.9.11
  Bump actions/cache from 2.1.5 to 2.1.7
  (maint) FIx spelling mistake
  Bump actions/cache from 2.1.4 to 2.1.5
  Bump cake-build/cake-action from 1 to 1.3.0
  (GH-849) Update Cake.Wyam reference from 2.2.10 to 2.2.12
  (#847) Bump CakeContrib.Guidelines to v1.1.1 to update NuGet package icon
  ...
cake-contrib-bot pushed a commit that referenced this issue Aug 8, 2022
Merge branch 'release/3.0.0'

* release/3.0.0: (59 commits)
  (#803) Remove usage of MyGet feed
  (build) Update to Cake 1.3.0
  (#723) Use alias for getting Arguments
  (#762) Update Cake and Cake.Issues.Recipe
  (#854) modified resolution of nuget
  (#854) modified resolution of RequireToolNotRegistered
  (GH-857) Update Cake.Coveralls reference from 1.0.1 to 1.1.0
  (GH-859) Update Cake.Gitter reference from 1.0.2 to 1.1.0
  (#862) bumped JetBrains.ReSharper.CommandLineTools
  (#873) Remove usage of DupFinder
  (#845) specified the full versions of GitHub actions
  Bump actions/checkout from 2.3.4 to 2.4.0
  Bump cake-build/cake-action from 1.3.0 to 1.4.0
  Bump gittools/actions from 0.9.9 to 0.9.11
  Bump actions/cache from 2.1.5 to 2.1.7
  (maint) FIx spelling mistake
  Bump actions/cache from 2.1.4 to 2.1.5
  Bump cake-build/cake-action from 1 to 1.3.0
  (GH-849) Update Cake.Wyam reference from 2.2.10 to 2.2.12
  (#847) Bump CakeContrib.Guidelines to v1.1.1 to update NuGet package icon
  ...
@cake-contrib-bot
Copy link
Contributor

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

cake-contrib-bot pushed a commit that referenced this issue Aug 8, 2022
Merge branch 'release/3.0.0'

* release/3.0.0: (59 commits)
  (#803) Remove usage of MyGet feed
  (build) Update to Cake 1.3.0
  (#723) Use alias for getting Arguments
  (#762) Update Cake and Cake.Issues.Recipe
  (#854) modified resolution of nuget
  (#854) modified resolution of RequireToolNotRegistered
  (GH-857) Update Cake.Coveralls reference from 1.0.1 to 1.1.0
  (GH-859) Update Cake.Gitter reference from 1.0.2 to 1.1.0
  (#862) bumped JetBrains.ReSharper.CommandLineTools
  (#873) Remove usage of DupFinder
  (#845) specified the full versions of GitHub actions
  Bump actions/checkout from 2.3.4 to 2.4.0
  Bump cake-build/cake-action from 1.3.0 to 1.4.0
  Bump gittools/actions from 0.9.9 to 0.9.11
  Bump actions/cache from 2.1.5 to 2.1.7
  (maint) FIx spelling mistake
  Bump actions/cache from 2.1.4 to 2.1.5
  Bump cake-build/cake-action from 1 to 1.3.0
  (GH-849) Update Cake.Wyam reference from 2.2.10 to 2.2.12
  (#847) Bump CakeContrib.Guidelines to v1.1.1 to update NuGet package icon
  ...
gep13 added a commit that referenced this issue Aug 8, 2022
* release/3.0.0:
  (#803) Remove usage of MyGet feed
  (build) Update to Cake 1.3.0
  (#723) Use alias for getting Arguments
  (#762) Update Cake and Cake.Issues.Recipe
cake-contrib-bot pushed a commit that referenced this issue Aug 8, 2022
Merge branch 'release/3.0.0' into develop

* release/3.0.0:
  (#803) Remove usage of MyGet feed
  (build) Update to Cake 1.3.0
  (#723) Use alias for getting Arguments
  (#762) Update Cake and Cake.Issues.Recipe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants