This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
OpenID Component Bug Fixes #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cakebaker
added a commit
that referenced
this pull request
May 3, 2012
cakebaker
added a commit
that referenced
this pull request
May 3, 2012
|
Thanks for your patch. I modified it a bit: |
kochb
added a commit
to kochb/openid-component
that referenced
this pull request
May 5, 2012
…kebaker#4. Conflicts: Controller/Component/OpenidComponent.php
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered two bugs while using the OpenID component that I've resolved.
One fixes an issue with the new request input format introduced CakePHP 2. The component was still expecting input in the CakePHP 1.x format.
The other resolves unexpected session disruptions due to the arbitrary call to session_start() in the openid construct. The fix I implemented was to write a custom Yadis session handler which explicitly runs all session updates through the CakeSession library. This has proven to be more reliable.