Merge pull request openid#70 from arnaud-lb/fix-call-time-pass-by-ref

Remove call-time pass-by-reference
cakebaker · Jul 31, 2012 · 705d5a6 · 705d5a6
2 parents d4e5efe + bb6da33
commit 705d5a6
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/Auth/OpenID/Consumer.php b/Auth/OpenID/Consumer.php
@@ -1183,9 +1183,11 @@ function _verifyDiscoveryResultsOpenID2($message, $endpoint)
     function _discoverAndVerify($claimed_id, $to_match_endpoints)
     {
         // oidutil.log('Performing discovery on %s' % (claimed_id,))
-        list($unused, $services) = call_user_func($this->discoverMethod,
-                                                  $claimed_id,
-                                                  &$this->fetcher);
+        list($unused, $services) = call_user_func_array($this->discoverMethod,
+                                                        array(
+                                                            $claimed_id,
+                                                            &$this->fetcher,
+                                                        ));
 
         if (!$services) {
             return new Auth_OpenID_FailureResponse(null,

diff --git a/Auth/OpenID/Server.php b/Auth/OpenID/Server.php
@@ -1704,7 +1704,7 @@ function handleRequest($request)
     {
         if (method_exists($this, "openid_" . $request->mode)) {
             $handler = array($this, "openid_" . $request->mode);
-            return call_user_func($handler, &$request);
+            return call_user_func_array($handler, array(&$request));
         }
         return null;
     }

diff --git a/Auth/Yadis/Manager.php b/Auth/Yadis/Manager.php
@@ -411,9 +411,11 @@ function getNextService($discover_cb, $fetcher)
         if (!$manager || (!$manager->services)) {
             $this->destroyManager();
 
-            list($yadis_url, $services) = call_user_func($discover_cb,
-                                                         $this->url,
-                                                         &$fetcher);
+            list($yadis_url, $services) = call_user_func_array($discover_cb,
+                                                               array(
+                                                                $this->url,
+                                                                &$fetcher,
+                                                               ));
 
             $manager = $this->createManager($services, $yadis_url);
         }