Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency versions. #57

Merged
merged 1 commit into from
Feb 15, 2017
Merged

Update dependency versions. #57

merged 1 commit into from
Feb 15, 2017

Conversation

ADmad
Copy link
Member

@ADmad ADmad commented Feb 15, 2017

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 15, 2017

Codecov Report

Merging #57 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #57   +/-   ##
=========================================
  Coverage     92.41%   92.41%           
  Complexity      204      204           
=========================================
  Files            22       22           
  Lines           514      514           
=========================================
  Hits            475      475           
  Misses           39       39

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daae760...dd15c4c. Read the comment docs.

"psr/http-message": "~1.0"
},
"require-dev": {
"cakephp/cakephp": "3.4.*@beta",
"cakephp/cakephp": "~3.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would Go with ^.
Projects can still lock it down more, but plugins should probably be a bit more open by default between minors.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~3.4 translates to >=3.4 <4.0.0 so it's open enough.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. As long as the last digit is not submitted, it will be the same as ^.

@burzum burzum merged commit ab60632 into master Feb 15, 2017
@lorenzo lorenzo deleted the deps branch February 15, 2017 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants