Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added composer.json #72

Merged
merged 3 commits into from Apr 17, 2014
Merged

Added composer.json #72

merged 3 commits into from Apr 17, 2014

Conversation

derekperkins
Copy link
Contributor

No description provided.

@markstory
Copy link
Member

Does phpcs work with composer installed standards yet?

@ADmad
Copy link
Member

ADmad commented Apr 16, 2014

Also wouldn't you need to require squizlabs/php_codesniffer? Without phpcs these standards by themselves would be unusable.

@jrbasso
Copy link
Member

jrbasso commented Apr 16, 2014

@markstory Yes, they have a composer version now. And I agree with @ADmad that requires the dependency of phpcs.

@derekperkins
Copy link
Contributor Author

All you have to do is specify a path to the standard. I'll add phpcs as a dependency.

From the manual at http://pear.php.net/manual/en/package.php.php-codesniffer.usage.php
Specifying an external coding standard
$ phpcs --standard=/path/to/MyStandard /path/to/code/myfile.inc

@derekperkins
Copy link
Contributor Author

The reason that I left out codesniffer as a dependency was to let the end user specify the version. I have this as the dependency in my project "squizlabs/php_codesniffer": "2.0.@dev", but I don't know what the standard itself should require. *? 1.? I left it as dev-master for now.

markstory added a commit that referenced this pull request Apr 17, 2014
@markstory markstory merged commit 43ec2ad into cakephp:master Apr 17, 2014
"irc": "irc://irc.freenode.org/cakephp",
"source": "https://github.com/cakephp/cakephp"
},
"require": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation looks off here. Probably tabs are used instead of spaces like rest of the file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the indentation after merging.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

@derekperkins
Copy link
Contributor Author

@markstory Thanks for merging that in. Has this been added to packagist yet? I wasn't able to load it this morning, but I didn't know if maybe there was a processing delay.

@markstory
Copy link
Member

I can add it now, I forgot to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants