New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added composer.json #72
Conversation
Does phpcs work with composer installed standards yet? |
Also wouldn't you need to require |
@markstory Yes, they have a composer version now. And I agree with @ADmad that requires the dependency of phpcs. |
All you have to do is specify a path to the standard. I'll add phpcs as a dependency. From the manual at http://pear.php.net/manual/en/package.php.php-codesniffer.usage.php |
The reason that I left out codesniffer as a dependency was to let the end user specify the version. I have this as the dependency in my project "squizlabs/php_codesniffer": "2.0.@dev", but I don't know what the standard itself should require. *? 1.? I left it as dev-master for now. |
"irc": "irc://irc.freenode.org/cakephp", | ||
"source": "https://github.com/cakephp/cakephp" | ||
}, | ||
"require": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation looks off here. Probably tabs are used instead of spaces like rest of the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the indentation after merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay
@markstory Thanks for merging that in. Has this been added to packagist yet? I wasn't able to load it this morning, but I didn't know if maybe there was a processing delay. |
I can add it now, I forgot to do that. |
No description provided.