-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CakePHP 2.3.6. Need one more Inflector rule for qouta/quotas noun #2077
Comments
25th Jun 2013, euromark said: If you check http://inflector.cakephp.org/ you will see that quota/quotas inflects correctly. What exactly does it say besides "table fails"? |
25th Jun 2013, SergeRod said: Your're right. Inflector works fine. Model baking process fails for table 'quotas' if model name passed as singular: 'Quota' (cake bake model Quota). The 'cake bake model Quotas' command works fine. |
26th Jun 2013, ADmad said: The problem lies in Shell::_modelName() which converts supplied model name
|
26th Jun 2013, ADmad said: The question is whether "Quota" itself is singular or plural. As per http://en.wiktionary.org/wiki/quota it seems quota can be used as singular. Native english speakers can decide :) |
Seems to be clear Quota = single (not a native English speaker though) |
This is an actual bug in the inflector. Any takers? |
I'll take a look. |
I'm confused. The new test cases proof everything is OK?
|
The inflector still runs on 2.3 afaik. And that quota fix was somewhere in 2.4 I imagine. |
@dereuromark Bad for using it in discussions in PRs and issues ;-) |
A spontaneous idea: |
Sure, PR that. |
@dereuromark According to the README it's running on 2.4... |
No, I upgraded it to "be able to run" with Cake2.4. But at the time, it was still not stable, so it was decided to keep 2.3. |
@dereuromark I'm already working on a PR which upgrades it. |
The PR with the upgrade: cakephp/inflector.cakephp.org#4 |
Created by SergeRod, 26th Jun 2013. (originally Lighthouse ticket #3890):
What I did
Inflector::singularize("quotas")
Inflector::pluralize("quota")
What happened
Baking model (cake bake model Quota) for 'quotas' table fails.
What I expected to happen
quota (singular) <==> quotas (plural)
The text was updated successfully, but these errors were encountered: