Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.0 - Add find() to ORM/Query instead of using __call #2293

Closed
markstory opened this issue Nov 9, 2013 · 1 comment
Closed

3.0 - Add find() to ORM/Query instead of using __call #2293

markstory opened this issue Nov 9, 2013 · 1 comment
Assignees
@markstory
Labels
enhancement models
Milestone
3.0.0

Comments

@markstory
Copy link
Member

After the discussion in #2287 we should remove the __call method in ORM\Query instead stacking finder methods should be done by calling find($type) on the query object.
@ghost ghost assigned markstory Nov 9, 2013
markstory added a commit to markstory/cakephp that referenced this issue Nov 9, 2013
@markstory
Convert Query::__call to a concrete method.
ad57e50 
Re-using the find() method makes Query and Table share the same
interface.

Fixes cakephp#2293
@markstory markstory mentioned this issue Nov 9, 2013
Merged
@markstory
Copy link
Member Author

Closing as the related pull request has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markstory markstory

Labels
enhancement models
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@markstory