EntityContext creates not valid children entities if parent has no children

[MichalWadowski]

I have Offer table associated to Customers with relation belongsToMany() (codes below are simplified for better reability):

public function initialize(array $config) {
   $this->belongsToMany("Customers", [
      'through' => 'OffersCustomers',
      'foreignKey' => 'offer_id',
   ]);
}

In CustomersTable.php:

public function validationDefault(Validator $validator) {
   $validator->notEmpty('company_name', function ($context) {
   return $context['providers']['entity']->isCompany();
});

I have add() controller action:

   public function add() {
   $offer = $this->Offers->newEntity($this->request->data, [
      'associated' => [
         'Customers'
      ]
   ]);
   $this->set('offer', $offer);
}

And view:

<?php echo $this->Form->create($offer); ?>
<?php echo $this->Form->input('customers.0.first_name'); ?>
<?php echo $this->Form->end(); ?>

Now, I can't display view, because I have unknown method error (isCompany() method not found). In CustomersTable in validation callback in $context['providers']['entity'] is stored Cake\ORM\Entity object, instead of App\Model\Entity\Customer.
In EntityContext.php method _getEntity($path) creates an entity by simple new Entity().
But if in POST data $this->request->data I have something like:

[
    'customers' => [
        (int) 0 => [
            'first_name' => 'dsa'
        ]
    ]
]

in $context['providers']['entity'] is stored App\Model\Entity\Customer object.

[lorenzo]

This features has a very high chance of being removed, once the validation code is reworked. This might influence our decision in what to do about this issue.

[markstory]

One solution that should work here is that instead of the base entity class being used by _getEntity() the respective table's newEntity() method should probably be used instead. I think this will solve the issue here.

[saraer]

same problem here.
I can not use entity method after post, like in validation error situation, because EntityContext::val() returns request->data(just array) before $entity check. I think if form is set by $entity data, EntityContext should respect $entity than request->data.

[markstory]

The reason it prefers request data is that there can be situations where request data does not get added into the entity. If I'm understanding you correctly the lookup order should be:

• Entity attribute
• If the field is not set on the entity, then check the request data.
• null.

[markstory]

@saraer How would I reproduce the issue you're running into. I'm not sure I fully understand it.

[saraer]

@markstory My problem was cleared by not using method in view. I think my problem is caused by my own coding way.
After all, I think lookup order should be entity attribute is first, but even if not, that'll be not maybe any problem. when I can find any another decent problem of this, I will post issue again.

[markstory]

Ok. I'll close this issue for now, and we can discuss further when a new issue comes up 😄