Issue 5190 pt1 #5206
Merged
Issue 5190 pt1 #5206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an association is undefined return a concrete entity class. This is necessary as notEmpty/allowEmpty callbacks could reference the entity provider. Refs #5190
|
I'm a bit reluctant to add more code around this, since the new validation code is progressing towards having to entity provider in the validator. This is a great solution for the current state of the code, though. |
|
I figure the two lines being added are unlikely to change as the context handler will still need to create empty entities when accessing non-existent association properties. |
|
Fair enough :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an annoying issue where notEmpty() callbacks would cause fatal errors as the entity would be the incorrect type.
Refs #5190