Make Redis::increment/decrement() set a TTL #10796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update doc blocks to acknowledge that TTLs are set now. Refs #10786
Because memcached doesn't allow cache keys to be incremented/decremented without a default value (unless you use the binary protocol), we don't need an explict TTL set as the key will have a TTL set when it is initially written. Refs #10786
Codecov Report
@@ Coverage Diff @@
## master #10796 +/- ##
============================================
+ Coverage 94.91% 94.91% +<.01%
+ Complexity 12122 12116 -6
============================================
Files 422 422
Lines 30123 30107 -16
============================================
- Hits 28591 28577 -14
+ Misses 1532 1530 -2
Continue to review full report at Codecov.
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the work done in #10786 and adding tests. I've not modified the Memcached driver as memcached values will have a TTL set when the key is initially created.
I am targeting
masterwith these changes as it is reasonable to expect that counters would work consistently across Redis and Memcached implementations (which they didn't) and these changes are normalizing behavior across backends.